Skip to content

Conversation

matteobettini
Copy link
Contributor

@matteobettini matteobettini commented Oct 16, 2025

Wow so basically the seeding test was using a random policy and implicitly relying on the fact that vmas.seed(0) was setting the global torch seed (so the policy was also seeded)

Now, since vmas.seed(0) is local (thanks to the changes we discussed on Discord) this implicit behavior emerged, confirming that local seeding works!

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 16, 2025
Copy link

pytorch-bot bot commented Oct 16, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3210

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures, 6 Unrelated Failures

As of commit f68038e with merge base 071d079 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@matteobettini matteobettini marked this pull request as draft October 16, 2025 21:17
@vmoens vmoens added the Environments Adds or modifies an environment wrapper label Oct 16, 2025
@matteobettini matteobettini marked this pull request as ready for review October 16, 2025 21:26
# Conflicts:
#	test/test_libs.py
@vmoens vmoens merged commit e954e97 into pytorch:main Oct 18, 2025
93 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Environments Adds or modifies an environment wrapper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants