Update python to 3.10 #3119

jainapurva · 2025-10-02T20:26:15Z

Update python to 3.10, as minimum supported version for pytorch2.9 onwards is python3.10

The following tests were failing and has been fixed as part of this PR:

test/quantization/pt2e/test_numeric_debugger.py::TestNumericDebuggerInfra::test_added_node_gets_unique_id
test/quantization/pt2e/test_numeric_debugger.py::TestNumericDebuggerInfra::test_copy_preserve_handle
test/quantization/pt2e/test_numeric_debugger.py::TestNumericDebuggerInfra::test_deepcopy_preserve_handle
test/quantization/pt2e/test_numeric_debugger.py::TestNumericDebuggerInfra::test_re_export_preserve_handle
test/quantization/pt2e/test_numeric_debugger.py::TestNumericDebuggerInfra::test_run_decompositions_map_handle_to_new_nodes
test/quantization/pt2e/test_numeric_debugger.py::TestNumericDebuggerInfra::test_run_decompositions_same_handle_id
test/quantization/pt2e/test_numeric_debugger.py::TestNumericDebuggerInfra::test_simple
test/quantization/pt2e/test_quantize_pt2e_qat.py::TestQuantizeMixQATAndPTQ::test_mixing_qat_ptq
test/quantization/pt2e/test_x86inductor_fusion.py::TestDynamicPatternMatcher::test_qconv2d_maxpool2d_linear_dynamic_cpu

…hon3.10

pytorch-bot · 2025-10-02T20:26:19Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3119

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 9 Pending

As of commit f95868a with merge base f64daac ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jagadish-amd · 2025-10-03T01:21:36Z

Thanks for the PR.
This should fix [build / build-manywheel-py3_9-rocm7_0] --> should be py3_10
ERROR: Could not find a version that satisfies the requirement torch (from versions: none)
ERROR: No matching distribution found for torch

jerryzh168 · 2025-10-06T21:55:20Z

test/quantization/pt2e/test_quantize_pt2e_qat.py


+    @unittest.skip("Skipping due to AssertionError: Guard failed: x.size()[0] == 1")
    def test_mixing_qat_ptq(self):
        example_inputs = (torch.randn(2, 3, 4, 4),)


seems easy to resolve, here it uses 1 for batch size:

ao/test/quantization/pt2e/test_quantize_pt2e_qat.py

Line 1107 in c96f2dd

example_input = (torch.rand((1, in_channels)),)

, just need to align with it I think

@jerryzh168 I''m skipping it for now, as the fix is not stable, and this PR is important to test release. We can re-evaluate the fix in another PR.

jerryzh168 · 2025-10-06T22:01:52Z

torchao/quantization/pt2e/_numeric_debugger.py

        return node_source

    def _is_node_in_original_graph(node: Node) -> bool:
+        # Handle guard nodes that don't have from_node metadata in newer PyTorch versions


@tugsbayasgalan is this change expected? should we using non-strict mode or strict mode?

ao/test/quantization/pt2e/test_numeric_debugger.py

Line 51 in c96f2dd

ep = torch.export.export(m, example_inputs, strict=True)

Yeah we made guard checking code as actual node in the graph so it makes sense this node doesn't have FROM_NODE. cc: @avikchaudhuri

@avikchaudhuri What's the best way to update this check?

seems like the current update is OK

jainapurva · 2025-10-07T19:48:51Z

test/quantization/pt2e/test_quantize_pt2e_qat.py

                    in_channels = child.linear1.weight.size(1)

-                example_input = (torch.rand((1, in_channels)),)
+                example_input = (torch.rand((2, 2, 2, in_channels)),)


@jerryzh168 Updating shapes here works, and doesn't give the guard dim mismatch error

why does it change for 2d to 4d?

The input is 4d, hence converting it to 4d works

ao/test/quantization/pt2e/test_quantize_pt2e_qat.py

Line 1131 in d3a0add

example_inputs = (torch.randn(2, 3, 4, 4),)

OK so the previous example_input is wrong, wondering why it works before

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:

Update python to 3.10, as minimum supprted version for pytorch is pyt…

ea93cbb

…hon3.10

jainapurva requested a review from janeyx99 October 2, 2025 20:26

meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2025

jainapurva requested a review from jerryzh168 October 2, 2025 20:26

Update all tests to run with python3.10

470fec1

jainapurva added the topic: for developers Use this tag if this PR is mainly developer facing label Oct 2, 2025

jerryzh168 approved these changes Oct 2, 2025

View reviewed changes

jainapurva added 2 commits October 5, 2025 21:22

Fix for dynamic shapes testing

eeddec5

Fix failing tests

d884463

jainapurva force-pushed the update_python_3_10 branch from 04a608c to d9f5a53 Compare October 6, 2025 21:21

failing tests

8aef270

jainapurva force-pushed the update_python_3_10 branch from d9f5a53 to 8aef270 Compare October 6, 2025 21:27

jainapurva mentioned this pull request Oct 6, 2025

Fix test_quantize_pt2e_qat.py::test_mixing_qat_ptq in CI #3125

Open

jerryzh168 reviewed Oct 6, 2025

View reviewed changes

jainapurva added 2 commits October 7, 2025 10:43

Fixes

a09c6e9

Merge branch 'main' into update_python_3_10

d3a0add

jainapurva force-pushed the update_python_3_10 branch from 89e39c9 to d3a0add Compare October 7, 2025 19:45

jainapurva commented Oct 7, 2025

View reviewed changes

jainapurva force-pushed the update_python_3_10 branch from 8610826 to f010095 Compare October 8, 2025 20:16

Updates

3e3fce6

jainapurva force-pushed the update_python_3_10 branch from f010095 to 3e3fce6 Compare October 9, 2025 06:05

jainapurva added 6 commits October 8, 2025 23:44

chore: trigger CI

70ce043

Fixes

1c54161

chore: trigger CI

bc6a0bf

chore: trigger CI

06ef2e9

trigger CI

9ad937f

<Replace this line with a title. Use 1 line only, 67 chars or less>

48455ee

Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:

jainapurva added 4 commits October 9, 2025 00:23

dummy test

3557e69

dummy test

cf3a4d9

dummy test

b6d8093

Remove dummy code

f95868a

jainapurva merged commit fd62d0e into main Oct 9, 2025
18 of 26 checks passed

jainapurva added a commit that referenced this pull request Oct 9, 2025

Update python to 3.10 (#3119)

a35fe4e

Update python to 3.10 #3119

Update python to 3.10 #3119

Uh oh!

Conversation

jainapurva commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3119

⏳ No Failures, 9 Pending

Uh oh!

jagadish-amd commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jainapurva commented Oct 2, 2025 •

edited

Loading

pytorch-bot bot commented Oct 2, 2025 •

edited

Loading

jagadish-amd commented Oct 3, 2025 •

edited

Loading