fix: fallback to 72 dpi when image header is 0 (#1494) #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagocborghi
changed the title
thiagocborghi
force-pushed
the
fix/zero-dpi-fallback
branch
from
06c03d6 to
df7b5bb
Compare
thiagocborghi
changed the title
rshah713
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 72-dpi fallback when an image header declares 0 dpi, preventing the
ZeroDivisionError reported in #1494.
The fix changes two getter methods (
horz_dpi/vert_dpi) and adds aregression test with a 0-dpi JPEG fixture.