Skip to content

fix: Raise more informative error instead of generic KeyError on end_stream #1307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: Raise more informative error instead of generic KeyError on end_stream #1307

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/h2/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -919,10 +919,14 @@ def end_stream(self, stream_id: int) -> None:
:param stream_id: The ID of the stream to end.
:type stream_id: ``int``
:returns: Nothing
:raises NoSuchStreamError: If the stream ID does not correspond to a
known stream and is higher than the current maximum stream ID.
:raises StreamClosedError: If the stream ID corresponds to a stream
that has been closed.
"""
self.config.logger.debug("End stream ID %d", stream_id)
self.state_machine.process_input(ConnectionInputs.SEND_DATA)
frames = self.streams[stream_id].end_stream()
frames = self._get_stream_by_id(stream_id).end_stream()
self._prepare_for_sending(frames)

def increment_flow_control_window(self, increment: int, stream_id: int | None = None) -> None:
Expand Down