Add the codejam winners to the k8s cluster #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
group: kubernetes
ChrisLovering
force-pushed
the
cj-winners
branch
from
b6605f4 to
926fc3f
Compare
OctoDNS Plan for
|
| Operation | Name | Type | TTL | Value | Source |
|---|---|---|---|---|---|
| Delete | gardenias | CNAME | 300 | linode-lb.box.pydis.wtf. | |
| Delete | monsteras | CNAME | 300 | linode-lb.box.pydis.wtf. | |
| Delete | tulips | CNAME | 300 | linode-lb.box.pydis.wtf. |
Summary: Creates=0, Updates=0, Deletes=3, Existing=35, Meta=False
These will be deleted once Johannes next takes his meds
There was a problem hiding this comment.
Pull Request Overview
Adds Kubernetes configuration for deploying the "monsteras" codejam winner application to the k8s cluster. The PR creates a complete deployment setup with service exposure and ingress routing.
- Creates Kubernetes deployment, service, and ingress resources for the monsteras application
- Configures TLS authentication and HTTPS routing through pythondiscord.com domain
- Sets up security contexts and container configurations for the application
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| kubernetes/namespaces/codejam-winners/monsteras/service.yaml | Defines service to expose the monsteras application on port 80 |
| kubernetes/namespaces/codejam-winners/monsteras/ingress.yaml | Configures ingress with TLS authentication and domain routing |
| kubernetes/namespaces/codejam-winners/monsteras/deployment.yaml | Sets up deployment with container specifications and security contexts |
| image: ghcr.io/python-discord/cj-monsteras | ||
| imagePullPolicy: Always | ||
| ports: | ||
| - containerPort: 80 |
There was a problem hiding this comment.
Port mismatch: the container exposes port 80 but the service targets port 8080. Either change containerPort to 8080 to match the service's targetPort, or update the service's targetPort to 80.
Suggested change
| - containerPort: 80 | |
| - containerPort: 8080 |
Copilot uses AI. Check for mistakes.
ChrisLovering
force-pushed
the
cj-winners
branch
from
926fc3f to
9e6caa1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be deleted once Johannes next takes his meds