Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
87 commits
Select commit Hold shift + click to select a range
10a017e
New feature : Model to estimate when a intervention had effect
JeanVanDyk May 28, 2025
69d79b3
New feature : Model to estimate when a intervention had effect
JeanVanDyk May 28, 2025
bf4eaaa
Minor fix in docstring
JeanVanDyk May 29, 2025
3420c9a
Minor fix in docstring
JeanVanDyk May 29, 2025
3dc23b3
Minor fix in docstring
JeanVanDyk May 29, 2025
d739b4a
Minor fix in docstring
JeanVanDyk May 29, 2025
d48f0c3
Minor fix in docstring
JeanVanDyk May 29, 2025
14afe09
Minor fix in docstring
JeanVanDyk May 29, 2025
60357a5
Minor fix in docstring
JeanVanDyk May 29, 2025
7f57b13
Minor fix in docstring
JeanVanDyk May 29, 2025
2cb92fc
Minor fix in docstring
JeanVanDyk May 29, 2025
d9c06ac
Minor fix in docstring
JeanVanDyk May 29, 2025
52cc0fa
Minor fix in docstring
JeanVanDyk May 29, 2025
faf085b
Minor fix in docstring
JeanVanDyk May 29, 2025
cc9a1f4
Minor fix in docstring
JeanVanDyk May 29, 2025
dea9d6e
Minor fix in docstring
JeanVanDyk May 29, 2025
5e9cde6
fix : hiding progressbar
JeanVanDyk May 30, 2025
ee701f2
Enhancement : Adding the possibility for the user to indicate priors …
JeanVanDyk May 30, 2025
5ee3cb4
Minor fix in docstring
JeanVanDyk Jun 4, 2025
08c520c
updating example notebook
JeanVanDyk Jun 4, 2025
b1681da
updating example notebook
JeanVanDyk Jun 4, 2025
fcfd059
Supporting Date format and adding exceptions for model related issues
JeanVanDyk Jun 4, 2025
64c97b7
changing column index restriction to label restriction
JeanVanDyk Jun 5, 2025
2996331
codespell
JeanVanDyk Jun 17, 2025
1da80fd
resolved merge
JeanVanDyk Jun 17, 2025
020f679
fixing merging issues
JeanVanDyk Jun 18, 2025
5039fda
fixing merging issues
JeanVanDyk Jun 18, 2025
4761b7e
codespell
JeanVanDyk Jun 18, 2025
bec5cd8
codespell
JeanVanDyk Jun 18, 2025
2d4d158
updating notebook
JeanVanDyk Jun 19, 2025
8d607b8
updating notebook with examples and adding time_variable_name parameter
JeanVanDyk Jun 20, 2025
d00f828
Merge branch 'main' into pr/480
drbenvincent Jun 20, 2025
942a1d5
fixing example
JeanVanDyk Jun 20, 2025
4aef14b
revert changes in docs and fixing issues
JeanVanDyk Jun 20, 2025
2b2cbdf
Removing the overriding of fit and calculate_impact, adding a test an…
JeanVanDyk Jun 20, 2025
6769aa7
Using all samples for uncertainty
JeanVanDyk Jun 23, 2025
692d85c
uml and docs
JeanVanDyk Jun 24, 2025
cc0979e
Changig Handler's name
JeanVanDyk Jul 8, 2025
72ebb8d
Adding the abstract class
JeanVanDyk Jul 8, 2025
d0f4a58
Updating the notebook
JeanVanDyk Jul 8, 2025
411aac7
Updating treatment type effect input
JeanVanDyk Jul 8, 2025
59db689
Updating integration test
JeanVanDyk Jul 8, 2025
4a10196
updating doctest
JeanVanDyk Jul 9, 2025
6de9707
Removing time variable
JeanVanDyk Jul 9, 2025
db8051f
Updating integration test
JeanVanDyk Jul 9, 2025
101d62a
Updating integration test to meet coverage reco
JeanVanDyk Jul 9, 2025
950623c
Updating notebook
JeanVanDyk Jul 9, 2025
5c4eb13
Updating integration test
JeanVanDyk Jul 9, 2025
6b1552a
typo
JeanVanDyk Jul 9, 2025
3ec5d69
updating notebook
JeanVanDyk Sep 23, 2025
ead382a
resolving conflicts
JeanVanDyk Sep 24, 2025
fd78418
resolving conflicts
JeanVanDyk Sep 24, 2025
1e5670b
resolving conflicts
JeanVanDyk Sep 24, 2025
0b669c9
resolving conflicts
JeanVanDyk Sep 24, 2025
3a693a1
resolving conflicts
JeanVanDyk Sep 24, 2025
42a7d1b
resolving conflicts
JeanVanDyk Sep 24, 2025
70c3426
resolving conflicts
JeanVanDyk Sep 24, 2025
e7b089a
resolving conflicts
JeanVanDyk Sep 24, 2025
eef8acb
resolving conflicts
JeanVanDyk Sep 24, 2025
9370efe
resolving conflicts
JeanVanDyk Sep 24, 2025
0c55851
resolving conflicts
JeanVanDyk Sep 24, 2025
f1a6622
resolving conflicts
JeanVanDyk Sep 24, 2025
d681a43
resolving conflicts
JeanVanDyk Sep 24, 2025
8b93362
resolving conflicts
JeanVanDyk Sep 24, 2025
67d696e
resolving conflicts
JeanVanDyk Sep 24, 2025
082d4d5
resolving conflicts
JeanVanDyk Sep 24, 2025
0a1b01e
resolving conflicts
JeanVanDyk Sep 24, 2025
c1fd388
resolving conflicts
JeanVanDyk Sep 24, 2025
d009b15
resolving conflicts
JeanVanDyk Sep 24, 2025
701fe13
resolving conflicts
JeanVanDyk Sep 24, 2025
46b453f
resolving conflicts
JeanVanDyk Sep 24, 2025
5318add
resolving conflicts
JeanVanDyk Sep 24, 2025
47cf44e
resolving conflicts
JeanVanDyk Sep 24, 2025
9bbc4cb
resolving conflicts
JeanVanDyk Sep 24, 2025
cf2a6f7
resolving conflicts
JeanVanDyk Sep 24, 2025
e5ee32c
resolve conflicts
JeanVanDyk Sep 24, 2025
7da8f91
removing errors in the notebook
JeanVanDyk Sep 26, 2025
c535061
Adding plot forest and comments to better compare models with and wit…
JeanVanDyk Sep 26, 2025
812cd4b
Adding mathjax formulas for examples
JeanVanDyk Sep 26, 2025
704066d
Typo
JeanVanDyk Sep 26, 2025
08463b5
Changing variables name in preprocessing
JeanVanDyk Sep 29, 2025
837e670
improving docstring
JeanVanDyk Sep 29, 2025
049c21b
adding references
JeanVanDyk Sep 29, 2025
cd51404
refining notebook
JeanVanDyk Sep 29, 2025
07ce191
adding ; after plots
JeanVanDyk Oct 1, 2025
7315283
small docstring update
drbenvincent Oct 3, 2025
bae5a12
add developer focussed module level docstring for ITS
drbenvincent Oct 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions causalpy/custom_exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,10 @@ class DataException(Exception):

def __init__(self, message: str):
self.message = message


class ModelException(Exception):
"""Exception raised given when there is some error in user-provided model"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some error? What's the value of the specific error class if it's quite unspecific?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to follow the approach used in the input_validation method. I noticed they relied on custom exceptions, so I figured that since none of the existing exceptions fit the issue I wanted to raise, it made sense to create my own, following the same pattern.

The idea is that someone might want to provide their own PyMC model for changepoint detection. Since the handler calls set_time_range during data preprocessing, it seems reasonable to require that user-provided models implement a set_time_range method.

Do you think it would be in fact just cleaner to remove it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's fine. I guess the docstring just threw me a bit, seemed redundant, but i get the idea of it.


def __init__(self, message: str):
self.message = message
Loading