Skip to content

Conversation

cha-ku
Copy link

@cha-ku cha-ku commented Sep 6, 2019

Hey @progsource, I tried to fix this, and this is working as seen in https://regex101.com/r/a40XyN/1, but in the code it compiles but gives me std::regex_error at runtime. I am unable to figure out what could be causing this. I am a complete beginner in C++ so it's possible I am missing something.

@progsource
Copy link
Owner

The regex tool says:

A quantifier following a lookaround serves no purpose, and can safely be removed from the regular expression

If I remove the + for both the places, where the tool says that, it runs again, but sadly not yet with the desired result.

I'll check on that more today.

@progsource
Copy link
Owner

progsource commented Sep 10, 2019

One of the problems, that I see here, is that the following

some (_text_) some more text

should actually result in

some (<em>text</em>) some more text

and

[some _text_ here](https://github.com/some_other_person)

should result in

[some <em>text</em> here](https://github.com/some_other_person)

@cha-ku
Copy link
Author

cha-ku commented Sep 10, 2019

Ok I will take a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants