fix: remove types/eslint peer dependency; fixes #762 #763

brettz9 · 2025-09-23T14:21:45Z

Important

Remove @types/eslint peer dependency and update pnpm version in package.json.

Peer Dependencies:
- Removed @types/eslint from peerDependencies in package.json.
- Removed @types/eslint from peerDependenciesMeta in package.json.
Package Manager:
- Updated packageManager to pnpm@10.17.1 in package.json.

^{This description was created by}^{for e22a182. You can customize this summary. It will automatically update as commits are pushed.}

Summary by CodeRabbit

Chores
- Upgraded package manager to pnpm 10.17.1 to align tooling and improve developer workflows.
- Removed an obsolete peer dependency and its optional metadata to streamline dependency management and reduce install warnings.
- Updated project changeset to reflect a major-impact release for the related plugin.
Tests
- Adjusted test imports to accommodate updated dependency behaviors (no user-facing changes).

changeset-bot · 2025-09-23T14:21:49Z

🦋 Changeset detected

Latest commit: cea2501

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-prettier	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2025-09-23T14:21:54Z

Warning

Rate limit exceeded

@brettz9 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 7ba06bc and cea2501.

📒 Files selected for processing (4)

.changeset/cyan-towns-type.md (1 hunks)
.github/workflows/ci.yml (2 hunks)
package.json (1 hunks)
test/prettier.mjs (2 hunks)

Walkthrough

Updated package metadata: bumped pnpm, removed @types/eslint peer entries, added a major changeset about that removal; adjusted a test import to use a namespace import from eslint-mdx.

Changes

Cohort / File(s)	Summary of Changes
Package configuration `package.json`	- `packageManager` updated: `pnpm@7.33.5` → `pnpm@10.17.1` - Removed `peerDependencies` entry for `@types/eslint` - Removed `peerDependenciesMeta` entry for `@types/eslint` (optional)
Changeset / Release notes `.changeset/cyan-towns-type.md`	- Added a major changeset documenting the removal of `@types/eslint` due to ESLint 9 conflicts; notes ESLint 8 users can re-add typings if needed; marks a major impact for `eslint-plugin-prettier`.
Tests `test/prettier.mjs`	- Changed import style: `import eslintMdx from 'eslint-mdx';` → `import * as eslintMdx from 'eslint-mdx';` (default → namespace import).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I thump my paws—pnpm hops ahead,
Typings gone, a tidy bed.
Tests adjust, imports rearranged,
Carrots crunched, the tree's not changed. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly and accurately describes the primary change — removal of the @types/eslint peer dependency — and includes the issue reference; it directly matches the package.json edits and the PR objectives and is clear and specific for teammates scanning history.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2025-09-23T14:22:24Z

Open in StackBlitz

npm i https://pkg.pr.new/eslint-plugin-prettier@763

commit: cea2501

ellipsis-dev

Important

Looks good to me! 👍

Reviewed everything up to e22a182 in 52 seconds. Click for details.

Reviewed 29 lines of code in 1 files
Skipped 0 files when reviewing.
Skipped posting 2 draft comments. View those below.
Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. package.json:13

Draft comment:
Updated packageManager to pnpm@10.17.1. Confirm that this upgrade is intentional and compatible with all build scripts.
Reason this comment was not posted:
Confidence changes required: 0% <= threshold 50% None

2. package.json:51

Draft comment:
Removed '@types/eslint' from peerDependencies and peerDependenciesMeta to resolve issue #762. ESLint 9 provides its own types; ESLint 8 users can still add it manually if needed.
Reason this comment was not posted:
Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_0fZrcb7ofi8kbV3A

^{You can customize}^{by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

package.json (1)

14-16: Consider aligning engines.node with toolchain reality

If the maintained toolchain (ESLint 9, pnpm 10) effectively requires Node ≥18, consider bumping engines.node accordingly or documenting the split between runtime and dev requirements.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between befda88 and 75ae48b.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

package.json (1 hunks)

🔇 Additional comments (2)

package.json (2)

51-60: Drop @types/eslint peer dep — confirm no lingering references

LGTM to remove; confirm locally that no references remain by searching for "@types/eslint", triple‑slash refs (/// ), or any imports from "@types/eslint" or "eslint".

13-13: pnpm v10 bump — verify Node.js compatibility (Node 18/20/22 required)

pnpm v10 requires Node.js 18/20/22; ensure package.json "engines.node" and all Node hints used by devs/CI (.nvmrc/.node-version, GitHub Actions actions/setup-node, Dockerfiles, contributor docs) target a compatible version or update "engines.node" to >=18. Automated scan returned no .nvmrc/.node-version or workflows in the repo — manually confirm those locations and CI configs are updated.

brettz9 · 2025-09-23T14:30:05Z

I've made a breaking change changeset just in case...

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

.changeset/cyan-towns-type.md (1)
5-5: Tighten wording and add guidance + formatting.

Clarify that it’s removed from peerDependencies, use code formatting, and suggest adding it to devDependencies for ESLint 8 users; reference the issue.
-Removes @types/eslint which now conflicts with ESLint 9. ESLint 8 users can still manually add @types/eslint if they so require.
+Remove `@types/eslint` from `peerDependencies` to avoid conflicts with ESLint 9 (types are bundled there).
+If you're on ESLint 8 and rely on typings, add `@types/eslint` to your project's `devDependencies`. See #762.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 75ae48b and c429ff0.

📒 Files selected for processing (1)

.changeset/cyan-towns-type.md (1 hunks)

🔇 Additional comments (1)

.changeset/cyan-towns-type.md (1)

1-3: Changeset header looks correct.

Major bump is appropriate for removing a peer dependency with potential consumer impact.

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

test/prettier.mjs (1)
22-22: Fix CI: import the MDX plugin via namespace (no default export).

The CI error shows eslint-plugin-mdx doesn’t export default. Switch to a namespace import.
-import eslintPluginMdx from 'eslint-plugin-mdx';
+import * as eslintPluginMdx from 'eslint-plugin-mdx';

🧹 Nitpick comments (1)

test/prettier.mjs (1)
27-27: Namespace import for eslint-mdx is fine; ensure the parser reference is correct.

When using * as eslintMdx, pass the actual parser object. Safer to reference default when present.
-    parser: eslintMdx,
+    parser: eslintMdx.default ?? eslintMdx,
Please re-run tests after the plugin import fix to confirm no parser resolution issues.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c429ff0 and 7ba06bc.

📒 Files selected for processing (1)

test/prettier.mjs (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: CI

test/prettier.mjs

[error] 22-22: SyntaxError: The requested module 'eslint-plugin-mdx' does not provide an export named 'default'. Update import to use the correct named export or dynamic import. This caused the 'pnpm mocha' test run to fail with exit code 1.

brettz9 · 2025-09-23T14:47:28Z

Though failing Node 14 and 16, this PR drops support for those versions (rolling in #761).

fix: remove types/eslint peer dependency; fixes prettier#762

e22a182

[autofix.ci] apply automated fixes

75ae48b

ellipsis-dev bot reviewed Sep 23, 2025

View reviewed changes

coderabbitai bot reviewed Sep 23, 2025

View reviewed changes

chore: add changeset

c429ff0

coderabbitai bot reviewed Sep 23, 2025

View reviewed changes

test: fix to namespaced import to cause tests to pass

e74093f

brettz9 force-pushed the types-eslint branch from 7ba06bc to e74093f Compare September 23, 2025 14:35

docs: improve per coderabbit nit

ea5082d

coderabbitai bot reviewed Sep 23, 2025

View reviewed changes

brettz9 added 2 commits September 23, 2025 22:42

chore: remove Node 14 and 16 support

f1ffcd0

test: coderabbit suggestion to utilize default if present

cea2501

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: remove types/eslint peer dependency; fixes #762 #763

fix: remove types/eslint peer dependency; fixes #762 #763

Uh oh!

brettz9 commented Sep 23, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 23, 2025 •

edited

Loading

Rate limit exceeded

Uh oh!

pkg-pr-new bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

ellipsis-dev bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

brettz9 commented Sep 23, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

brettz9 commented Sep 23, 2025

Uh oh!

Uh oh!

Uh oh!

fix: remove types/eslint peer dependency; fixes #762 #763

Are you sure you want to change the base?

fix: remove types/eslint peer dependency; fixes #762 #763

Uh oh!

Conversation

brettz9 commented Sep 23, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitai bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

pkg-pr-new bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ellipsis-dev bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

brettz9 commented Sep 23, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

brettz9 commented Sep 23, 2025

Uh oh!

Uh oh!

brettz9 commented Sep 23, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented Sep 23, 2025 •

edited

Loading

coderabbitai bot commented Sep 23, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 23, 2025 •

edited

Loading