See whether always cloning improves perf and helps with mem issue

[JoviDeCroock]

TODO:

• Verify it fixes leaks
• Copy smaller create-element of Always clone VNodes before using them #3710
• Fix tests

[github-actions]

📊 Tachometer Benchmark Results

Summary

duration

• create10k: unsure 🔍 -0% - +1% (-2.90ms - +5.72ms)
  ^{preact-local vs preact-main}
• filter-list: unsure 🔍 -0% - +1% (-0.03ms - +0.15ms)
  ^{preact-local vs preact-main}
• hydrate1k: unsure 🔍 -2% - +3% (-1.21ms - +2.12ms)
  ^{preact-local vs preact-main}
• many-updates: faster ✔ 4% - 9% (0.60ms - 1.58ms)
  ^{preact-local vs preact-main}
• replace1k: unsure 🔍 -0% - +2% (-0.06ms - +1.09ms)
  ^{preact-local vs preact-main}
• text-update: slower ❌ 2% - 9% (0.04ms - 0.16ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -0% - +1% (-0.14ms - +0.17ms)
  ^{preact-local vs preact-main}
• update10th1k: slower ❌ 8% - 16% (2.51ms - 4.64ms)
  ^{preact-local vs preact-main}

usedJSHeapSize

• create10k: slower ❌ 27% - 27% (5.12ms - 5.12ms)
  ^{preact-local vs preact-main}
• filter-list: slower ❌ 4% - 5% (0.06ms - 0.07ms)
  ^{preact-local vs preact-main}
• hydrate1k: slower ❌ 9% - 29% (0.64ms - 1.83ms)
  ^{preact-local vs preact-main}
• many-updates: slower ❌ 21% - 21% (0.78ms - 0.78ms)
  ^{preact-local vs preact-main}
• replace1k: slower ❌ 17% - 17% (0.51ms - 0.52ms)
  ^{preact-local vs preact-main}
• text-update: unsure 🔍 -2% - +2% (-0.02ms - +0.02ms)
  ^{preact-local vs preact-main}
• todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
  ^{preact-local vs preact-main}
• update10th1k: slower ❌ 17% - 18% (0.51ms - 0.52ms)
  ^{preact-local vs preact-main}

Results

create10k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5137

• Commit: 18b4a3f

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1018.41ms - 1023.95ms	-	unsure 🔍 -0% - +1% -2.90ms - +5.72ms
preact-main	1016.46ms - 1023.06ms	unsure 🔍 -1% - +0% -5.72ms - +2.90ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.16ms - 24.16ms	-	slower ❌ 27% - 27% 5.12ms - 5.12ms
preact-main	19.04ms - 19.04ms	faster ✔ 21% - 21% 5.12ms - 5.12ms	-

filter-list

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5137

• Commit: 18b4a3f

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	16.51ms - 16.68ms	-	unsure 🔍 -0% - +1% -0.03ms - +0.15ms
preact-main	16.51ms - 16.56ms	unsure 🔍 -1% - +0% -0.15ms - +0.03ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.60ms - 1.61ms	-	slower ❌ 4% - 5% 0.06ms - 0.07ms
preact-main	1.53ms - 1.54ms	faster ✔ 4% - 4% 0.06ms - 0.07ms	-

hydrate1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5137

• Commit: 18b4a3f

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	68.25ms - 70.18ms	-	unsure 🔍 -2% - +3% -1.21ms - +2.12ms
preact-main	67.41ms - 70.12ms	unsure 🔍 -3% - +2% -2.12ms - +1.21ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	7.26ms - 8.27ms	-	slower ❌ 9% - 29% 0.64ms - 1.83ms
preact-main	6.22ms - 6.84ms	faster ✔ 9% - 23% 0.64ms - 1.83ms	-

many-updates

• Browser: chrome-headless
• Sample size: 100
• Built by: CI #5137

• Commit: 18b4a3f

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	15.14ms - 16.06ms	-	faster ✔ 4% - 9% 0.60ms - 1.58ms
preact-main	16.52ms - 16.85ms	slower ❌ 4% - 10% 0.60ms - 1.58ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	4.49ms - 4.50ms	-	slower ❌ 21% - 21% 0.78ms - 0.78ms
preact-main	3.72ms - 3.72ms	faster ✔ 17% - 17% 0.78ms - 0.78ms	-

replace1k

• Browser: chrome-headless
• Sample size: 100
• Built by: CI #5137

• Commit: 18b4a3f

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	61.64ms - 62.46ms	-	unsure 🔍 -0% - +2% -0.06ms - +1.09ms
preact-main	61.13ms - 61.94ms	unsure 🔍 -2% - +0% -1.09ms - +0.06ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.50ms - 3.50ms	-	slower ❌ 17% - 17% 0.51ms - 0.52ms
preact-main	2.98ms - 2.99ms	faster ✔ 15% - 15% 0.51ms - 0.52ms	-

run-warmup-0

Version	Avg time	vs preact-local	vs preact-main
preact-local	25.95ms - 26.67ms	-	slower ❌ 3% - 7% 0.75ms - 1.78ms
preact-main	24.68ms - 25.41ms	faster ✔ 3% - 7% 0.75ms - 1.78ms	-

run-warmup-1

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.38ms - 34.35ms	-	slower ❌ 3% - 7% 1.02ms - 2.37ms
preact-main	31.70ms - 32.64ms	faster ✔ 3% - 7% 1.02ms - 2.37ms	-

run-warmup-2

Version	Avg time	vs preact-local	vs preact-main
preact-local	34.76ms - 35.70ms	-	slower ❌ 11% - 15% 3.35ms - 4.54ms
preact-main	30.93ms - 31.64ms	faster ✔ 10% - 13% 3.35ms - 4.54ms	-

run-warmup-3

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.91ms - 25.86ms	-	slower ❌ 1% - 5% 0.28ms - 1.28ms
preact-main	24.45ms - 24.76ms	faster ✔ 1% - 5% 0.28ms - 1.28ms	-

run-warmup-4

Version	Avg time	vs preact-local	vs preact-main
preact-local	24.84ms - 25.21ms	-	faster ✔ 0% - 6% 0.10ms - 1.58ms
preact-main	25.15ms - 26.58ms	slower ❌ 0% - 6% 0.10ms - 1.58ms	-

run-final

Version	Avg time	vs preact-local	vs preact-main
preact-local	19.87ms - 20.36ms	-	faster ✔ 1% - 4% 0.19ms - 0.90ms
preact-main	20.41ms - 20.91ms	slower ❌ 1% - 4% 0.19ms - 0.90ms	-

text-update

• Browser: chrome-headless
• Sample size: 250
• Built by: CI #5137

• Commit: 18b4a3f

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.91ms - 2.01ms	-	slower ❌ 2% - 9% 0.04ms - 0.16ms
preact-main	1.83ms - 1.89ms	faster ✔ 2% - 8% 0.04ms - 0.16ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	0.99ms - 1.01ms	-	unsure 🔍 -2% - +2% -0.02ms - +0.02ms
preact-main	0.99ms - 1.02ms	unsure 🔍 -2% - +2% -0.02ms - +0.02ms	-

todo

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5137

• Commit: 18b4a3f

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	31.47ms - 31.70ms	-	unsure 🔍 -0% - +1% -0.14ms - +0.17ms
preact-main	31.47ms - 31.68ms	unsure 🔍 -1% - +0% -0.17ms - +0.14ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	1.25ms - 1.25ms	-	unsure 🔍 -0% - +0% -0.00ms - +0.00ms
preact-main	1.25ms - 1.25ms	unsure 🔍 -0% - +0% -0.00ms - +0.00ms	-

update10th1k

• Browser: chrome-headless
• Sample size: 50
• Built by: CI #5137

• Commit: 18b4a3f

duration

Version	Avg time	vs preact-local	vs preact-main
preact-local	33.09ms - 34.61ms	-	slower ❌ 8% - 16% 2.51ms - 4.64ms
preact-main	29.52ms - 31.03ms	faster ✔ 8% - 14% 2.51ms - 4.64ms	-

usedJSHeapSize

Version	Avg time	vs preact-local	vs preact-main
preact-local	3.45ms - 3.46ms	-	slower ❌ 17% - 18% 0.51ms - 0.52ms
preact-main	2.93ms - 2.94ms	faster ✔ 15% - 15% 0.51ms - 0.52ms	-

_{tachometer-reporter-action v2 for CI}

[github-actions]

Size Change: -22 B (-0.05%)

Total Size: 47.3 kB

Filename	Size	Change
dist/preact.js	4.67 kB	-7 B (-0.15%)
dist/preact.mjs	4.69 kB	-7 B (-0.15%)
dist/preact.umd.js	4.75 kB	-8 B (-0.17%)

ℹ️ View Unchanged

Filename	Size
compat/dist/compat.js	3.9 kB
compat/dist/compat.mjs	3.82 kB
compat/dist/compat.umd.js	3.95 kB
debug/dist/debug.js	3.9 kB
debug/dist/debug.mjs	3.9 kB
debug/dist/debug.umd.js	3.98 kB
devtools/dist/devtools.js	263 B
devtools/dist/devtools.mjs	273 B
devtools/dist/devtools.umd.js	348 B
hooks/dist/hooks.js	1.53 kB
hooks/dist/hooks.mjs	1.56 kB
hooks/dist/hooks.umd.js	1.6 kB
jsx-runtime/dist/jsxRuntime.js	892 B
jsx-runtime/dist/jsxRuntime.mjs	861 B
jsx-runtime/dist/jsxRuntime.umd.js	966 B
test-utils/dist/testUtils.js	473 B
test-utils/dist/testUtils.mjs	473 B
test-utils/dist/testUtils.umd.js	555 B

_{compressed-size-action}

[coveralls]

coverage: 98.512% (-1.0%) from 99.535%
when pulling 18b4a3f on see-perf-diff-of-node-cloning
into 027142c on main.