Better control of ScaleBar thickness. #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open questions: - Should width_fraction be deprecated? - Should length_fraction get the same treatment? If so, should fixed_value/fixed_units be rolled into `length`, e.g. as `length=(1, "um")`?
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
==========================================
- Coverage 91.46% 89.62% -1.85%
==========================================
Files 3 3
Lines 422 482 +60
==========================================
+ Hits 386 432 +46
- Misses 36 50 +14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ppinard Kindly bumping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69. There is a slight backwards incompatibility regarding the rcParams (I just brutally replace the scalebar.width_fraction entry by scalebar.thickness), which is rather annoying to make fully backcompatible. But I can try to improve on that if that's something you care about and if you agree about the rest of the general design.
Open questions:
length, e.g. aslength=(1, "um")?