Autodetect dimension from units. #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets one write `ScaleBar(1, "kpc")` instead of the slightly redundant `ScaleBar(1, "kpc", "astro-length")`. Note that changes only occur in the constructor; "auto" is not when later calling set_dimension (directly or via the property) because that property's mutable semantics seem a bit fuzzy anyways: what happens if one sets the dimension to something incompatible with the units? I would believe `ScaleBar.dimension` should be a readonly property directly derived from `ScaleBar.units`.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 91.46% 91.93% +0.46%
==========================================
Files 3 3
Lines 422 459 +37
==========================================
+ Hits 386 422 +36
- Misses 36 37 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets one write
ScaleBar(1, "kpc")instead of the slightly redundantScaleBar(1, "kpc", "astro-length").Note that changes only occur in the constructor; "auto" is not when later calling set_dimension (directly or via the property) because that property's mutable semantics seem a bit fuzzy anyways: what happens if one sets the dimension to something incompatible with the units? I would believe
ScaleBar.dimensionshould be a readonly property directly derived fromScaleBar.units.Closes #70.