Skip to content

Conversation

flo-dup
Copy link
Contributor

@flo-dup flo-dup commented Sep 10, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • A PR or issue has been opened in all impacted repositories (if any)

Does this PR already have an issue describing the problem?
No

What kind of change does this PR introduce?
Dependency update

What is the current behavior?
network-viewer v1.10.1

What is the new behavior (if this is a feature change)?
network-viewer v1.11.0

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

Signed-off-by: Florian Dupuy <florian.dupuy@rte-france.com>
@flo-dup
Copy link
Contributor Author

flo-dup commented Sep 10, 2025

In nad-viewer, the voltage level nodes and the text nodes are hoverable, but we shouldn't add a tooltip for them. We could maybe only filter out those hovering instead of what I just did?

@CBiasuzzi
Copy link
Contributor

what you did was setting the default tooltip to the empty string, when the type is not recognized.
Maybe as you suggested filtering out those two types, explicily could be a better option?
(leaving the default tooltip "Equipment of type '{type}' with id '{id}' , also to help spotting types that are still not handled, in the future)

elif type in [ 'VOLTAGE_LEVEL', 'TEXT_NODE']:
        return ''
    return f"Equipment of type '{type}' with id '{id}'"

… from the hovering

Signed-off-by: Christian Biasuzzi <christian.biasuzzi@soft.it>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants