-
Notifications
You must be signed in to change notification settings - Fork 980
Feat/multi languages support #117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Multi-language support for the entire application is now complete: Language Configuration - 37 languages supported Settings UI - language selection dropdown Settings Store - language preference persistence STT Provider - OpenAI, Gemini, Whisper support for multi-language LLM Provider - Ask functionality supports multi-language response Live insights - multi-language support is now supported too! Language Analytics Application Integration - Load language settings on startup
Passed with quick tests and manual test
Hey @TiteTia thanks for contribution! Nice work for language support! Really appreciate it. However, after I dive into review, I think 3 main points needed:
I guess we need to toss the language at "listenService.initializeSession()"
which is in windowManager.js's toggle-feature ipc handler.
Could you please update these? Thanks for your effort! |
Hi @samtiz ! |
@TiteTia can you clean up the commits - perhaps squash them? |
Updated the session initialization in createWindows to retrieve the current language setting using getSettings and pass it to listenService.initializeSession. If fetching the language fails, it defaults to 'en'. This ensures the session starts with the correct language context. Remove all multi-language test files Deleted the entire tests directory, including unit, integration, and end-to-end test files, Jest configuration, test runner scripts, and related documentation. This removes all automated testing and test documentation for multi-language support. Update with new windowManager.js
598df42
to
e1d858e
Compare
Hi @RONNCC I just squashed the commits |
@samtiz @RONNCC Hi, I just saw the code has been refactored, since the code and structure have been changed a lot from previous version. I may not have time/ability to rewrite the entire feature to adapt to the new structure. If there are someone could help me adapt with the new structure that will be great for this feature. |
Multi-language support for the entire application is now complete: Language Configuration - 37 languages supported
Settings UI - language selection dropdown
Settings Store - language preference persistence
STT Provider - OpenAI, Gemini, Whisper support for multi-language LLM Provider - Ask functionality supports multi-language response Live insights - multi-language support is now supported too! Language Analytics Application Integration - Load language settings on startup
name: Pull Request
about: Propose a change to the codebase
Summary of Changes
Add Multi-Languages Support for Glass
Multi-language support for the entire application is now complete:
Language Configuration - 37 languages supported
Settings UI - language selection dropdown
Settings Store - language preference persistence
STT Provider - OpenAI, Gemini, Whisper support for multi-language
LLM Provider - Ask functionality supports multi-language response
Live insights - multi-language support is now supported too! Language Analytics
Application Integration - Load language settings on startup
Related Issue
Please replace
XXX
with the issue number that this pull request resolves. If it does not resolve a specific issue, please explain why this change is needed.Contributor's Self-Review Checklist
Please check the boxes that apply. This is a reminder of what we look for in a good pull request.
Additional Context (Optional)
Add any other context or screenshots about the pull request here.