-
Notifications
You must be signed in to change notification settings - Fork 9
feat: add Card Fields example #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mchoun
wants to merge
4
commits into
main
Choose a base branch
from
feature/add-card-fields-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregjopa
reviewed
Aug 4, 2025
client/components/cardFields/oneTimePayment/html/src/recommended/index.html
Outdated
Show resolved
Hide resolved
gregjopa
reviewed
Aug 4, 2025
client/components/cardFields/oneTimePayment/html/src/recommended/index.html
Outdated
Show resolved
Hide resolved
2b5f38d
to
04def78
Compare
gregjopa
reviewed
Sep 25, 2025
// }); | ||
|
||
// NOTE: Eligibility does not currently return card | ||
// if (paymentMethods.isEligible("card")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we enable this eligibility check?
Suggested change
// if (paymentMethods.isEligible("card")) { | |
if (paymentMethods.isEligible("card")) { |
kand
reviewed
Sep 25, 2025
Comment on lines
+17
to
+19
| Sample Integration | Description | | ||
| ----------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| [Recommended](src/recommended/index.html) | Start with this recommended sample integration. It displays all buttons supported by the v6 SDK and includes eligibility logic. It uses the "auto" presentation mode which attempts to launch a popup window and then automatically falls back to the modal presentation mode when the browser does not support popups. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be updated?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add an example for One Time Payment Card Fields as well as Save Payment Method Card Fields integrations.