Skip to content

feat(Radio/Checkbox): support for aria-describedBy #12042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(Radio/Checkbox): support for aria-describedBy #12042

wants to merge 2 commits into from
+120 −5

Conversation

gitdallas
Copy link
Contributor

Closes #9695

@gitdallas
feat(Radio/Checkbox): support for aria-describedBy
42bb1b1 
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 4, 2025 •
edited
Loading

Preview: https://pf-react-pr-12042.surge.sh

A11y report: https://pf-react-pr-12042-a11y.surge.sh

@gitdallas
lints
1eba459 
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
@gitdallas gitdallas force-pushed the feat/9695-checkbox-radio-aria-describedby branch from a15e207 to 1eba459 Compare October 5, 2025 14:55
mcoker
mcoker approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though since there is no shiny CSS/UI stuff here, I'm just testing that it works like expected.

  • Passing aria-describedby='' both with and without a description prevented aria-describedby from rendering ✅
  • Passing aria-describedby="foo" rendered aria-describedby="foo" both with and without a description ✅
  • Not passing aria-describedby did nothing if there is no description ✅
  • Not passing aria-describedby with a description properly added aria-description="id-of-description" ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@mcoker mcoker mcoker approved these changes

@thatblindgeye thatblindgeye Awaiting requested review from thatblindgeye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checkbox/Radio - add support for aria-describedby
4 participants
@gitdallas @patternfly-build @wise-king-sullyman @mcoker