Skip to content

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Sep 15, 2025

testing #1520 with #1563

- Refactors the GraphQL common utilities into a single package
- Refactors the V4 HTTP package into multiple files (lint)
@YOU54F YOU54F force-pushed the feat/v4-asynchronous-messages-pact-core-v17 branch from c35ad0f to 5714684 Compare September 15, 2025 18:36
Depends on upstream change here: https://github.com/pact-foundation/pact-js-core/pull/662

## Breaking changes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mefellows

I decided to do MatchersV3 at the same time. It felt like it made sense.


// Arrange
provider
.addInteraction(indexInteraction)
Copy link
Member Author

@YOU54F YOU54F Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought it would be nice to show a usecase with multiple interactions in a single test (Pact Broker Client traverses multiple calls via HAL relations) and see what it lookss like.

It feels like it would be nice to chain an addInteraction off a willRespondWith here

//
// We need to setup two interactions in Pact to handle this

// TODO: This would be more ergonomic, if we could chain adding a new
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note the TODO.

Having a first class way of adding a second interaction here, rather than it just working via what looks like magic :)

V4InteractionWithResponse won't allow chaining of a V4UnconfiguredInteraction.

Could addInteraction accept a configured interaction?

I assume for most parts having it for the http interactions would be suitable, or only allow chaining of similar interaction types. Haven't though too much of whether it would apply for messaging, but may need to be considered for plugin interactions.

@YOU54F YOU54F mentioned this pull request Sep 16, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants