-
Notifications
You must be signed in to change notification settings - Fork 109
fix(account-creation): add siren field in account creation #19818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aottr
reviewed
Oct 17, 2025
packages/manager/apps/account-creation/src/pages/accountDetails/accountDetails.page.tsx
Outdated
Show resolved
Hide resolved
aottr
reviewed
Oct 17, 2025
packages/manager/apps/account-creation/src/pages/accountDetails/accountDetails.page.tsx
Outdated
Show resolved
Hide resolved
aottr
approved these changes
Oct 17, 2025
Note: before merging you'll need to squash your commits into one to follow the commit quality guideline ("Commits should be atomic, meaning they should represent a single logical change or feature") |
d23e324
to
7954f77
Compare
packages/manager/apps/account-creation/src/pages/accountDetails/accountDetails.page.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/account-creation/src/pages/accountDetails/accountDetails.page.tsx
Outdated
Show resolved
Hide resolved
packages/manager/apps/account-creation/src/helpers/flowHelper.ts
Outdated
Show resolved
Hide resolved
22dbb78
to
cb4a91d
Compare
9a750d1
to
241de68
Compare
cb4a91d
to
82d2b15
Compare
82d2b15
to
b788176
Compare
fffb044
to
3c18785
Compare
241de68
to
46c1f21
Compare
ref: #MANAGER-20005 Signed-off-by: achraf hafedh <achraf.hafedh.ext@ovhcloud.com>
3c18785
to
9b13610
Compare
JacquesLarique
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #MANAGER-20005
Description
add siren field in account creation
Ticket Reference: #MANAGER-20005
Additional Information