feat(pcos): guide info #19814
Merged
feat(pcos): guide info #19814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel95200x
requested review from
Tsiorifamonjena,
aTurmo,
fredericvilcot,
lolottetheclash,
manoncarbonnel and
ppprevost
| return ( | ||
| <> | ||
| <h2>{t('dashboardTitle')}</h2> | ||
| <div className="flex justify-between w-full items-center"> |
There was a problem hiding this comment.
Maybe this piece of code could be refactored? Because I've seen it several times on the PR. Whatever you think is best!
| onGuideClick(guide); | ||
| } | ||
| const { url } = guide; | ||
| if (url && /^(http|https):\/\//i.test(url)) { |
There was a problem hiding this comment.
it could be extracted in a regex with some tests
| <CommandEmpty>{t('guidesNoResults')}</CommandEmpty> | ||
| <CommandGroup data-testid="guide-header" heading={t('guidesTitle')}> | ||
| {guides | ||
| ?.sort((a, b) => a.title.localeCompare(b.title)) |
There was a problem hiding this comment.
it could be extracted in a function outside JSX
github-actions
bot
added
translation required
universe-public-cloud
feature
lionel95200x
force-pushed
the
feat/pcos-guides
branch
from
ad9aa60 to
6e24209
Compare
Signed-off-by: Lionel Bueno <lionel.bueno.ext@ovhcloud.com>
lionel95200x
force-pushed
the
feat/pcos-guides
branch
from
6e24209 to
9bcc50e
Compare
jperchoc
approved these changes
Oct 20, 2025
lolottetheclash
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket Reference: #...
Additional Information