Skip to content

Conversation

@FarhanAnjum-opti
Copy link
Contributor

Summary

Decision Service methods to handle CMAB

Test plan

Added unit tests

Issues

FSSDK-11175

@Mat001 Mat001 requested review from Mat001 and raju-opti June 16, 2025 18:43
…essages and add a test for handling 500 errors
…lt and updating get_variation return type to include detailed error information
-test cases changed to handle return type dicts of DecisionResult and VariationResult
Copy link
Contributor

@Mat001 Mat001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Have Raju review too.

Copy link

@raju-opti raju-opti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with few small comments

@FarhanAnjum-opti FarhanAnjum-opti merged commit 81f5be9 into master Jul 7, 2025
23 checks passed
@FarhanAnjum-opti FarhanAnjum-opti deleted the farhan-anjum/FSSDK-11175-add-decision-service-methods-for-cmab branch July 7, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants