Skip to content

Revert number inputs for fields with labels on the problem set detail page. #2823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2025
Merged

Revert number inputs for fields with labels on the problem set detail page. #2823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions lib/WeBWorK/ContentGenerator/Instructor/ProblemSetDetail.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ use constant FIELD_PROPERTIES => {
},
max_attempts => {
name => x('Max Attempts'),
type => [ -1, undef, 1 ],
type => 'edit',
size => 6,
override => 'any',
default => '-1',
Expand All @@ -493,10 +493,10 @@ use constant FIELD_PROPERTIES => {
},
showMeAnother => {
name => x('Show Me Another'),
type => [ -2, undef, 1 ],
type => 'edit',
size => '6',
override => 'any',
default => '-1',
default => '-2',
labels => {
'-1' => x('Never'),
'-2' => x('Course Default'),
Expand All @@ -509,7 +509,7 @@ use constant FIELD_PROPERTIES => {
},
showHintsAfter => {
name => x('Show Hints After'),
type => [ -2, undef, 1 ],
type => 'edit',
size => '6',
override => 'any',
default => '-2',
Expand All @@ -526,7 +526,7 @@ use constant FIELD_PROPERTIES => {
},
prPeriod => {
name => x('Rerandomize After'),
type => [ -1, undef, 1 ],
type => 'edit',
size => '6',
override => 'any',
default => '-1',
Expand Down Expand Up @@ -606,7 +606,7 @@ use constant FIELD_PROPERTIES => {
},
att_to_open_children => {
name => x('Attempt Threshold for Children'),
type => [ -1, undef, 1 ],
type => 'edit',
size => 6,
override => 'any',
default => '0',
Expand Down Expand Up @@ -960,10 +960,9 @@ sub fieldHTML ($c, $userID, $setID, $problemID, $globalRecord, $userRecord, $fie
} elsif ($number) {
$input = $c->number_field(
@field_args,
min => ($properties{type}[0] || 0),
max => ($properties{type}[1] || undef),
step => ($properties{type}[2] || 1),
placeholder => $value,
min => ($properties{type}[0] || 0),
max => ($properties{type}[1] || undef),
step => ($properties{type}[2] || 1),
$forUsers && $canOverride ? (placeholder => $c->maketext('Set Default')) : ()
);
} else {
Expand Down