Revert number inputs for fields with labels on the problem set detail page. (hotfix) #2822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
changed the title
drgrice1
force-pushed
the
bugfix/problem-set-details-number-settings-hotfix
branch
from
b145145 to
3f27520
Compare
|
Note that this also does not set the |
… page. This is a quick fix that will make things function for now, and is good for a hotfix. This just reverts all of the fields that were switched to number inputs and that have labels for special negative values back to text inputs and the functionality prior to WeBWorK 2.20. The fields that do not have those labels can still be number inputs. That will work fine for those. Also set the default for showMeAnother to the "Course Default" instead of "Never" which is what it should be. This resolves issue openwebwork#2820 for the current release. We can try to do better for the next release, but I don't see any other easy way to fix this that is appropriate for a hotfix.
drgrice1
force-pushed
the
bugfix/problem-set-details-number-settings-hotfix
branch
from
3f27520 to
0eea5e0
Compare
somiaj
approved these changes
Sep 18, 2025
dlglin
approved these changes
Sep 23, 2025
drgrice1
deleted the
bugfix/problem-set-details-number-settings-hotfix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick fix that will make things function for now, and is good for a hotfix. This just reverts all of the fields that were switched to number inputs and that have labels for special negative values back to text inputs and the functionality prior to WeBWorK 2.20.
The fields that do not have those labels can still be number inputs. That will work fine for those.
This resolves issue #2820 for the current release.
We can try to do better for the next release, but I don't see any other easy way to fix this that is appropriate for a hotfix.