replace scaffold yellow with lightblue #1094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the yellow background in scaffold problem headers with lightblue. This is the color that is used on a section's header/button when you are able to open/close that section and do not yet have that section correctly answered. Note that gray is used when you do not yet have access to a section, and lightgreen is used when you have answered that section correctly.
To me the yellow is just too...yellow.
This looks fine (to me) in all four themes, but perhaps the yellow theme needs special attention. Although, to me the current scaffold yellow is so bright that even in the yellow theme, I don't think it looks good.
If people like this and we're still doing non-critical hotfixes, I can open another PR. I'm assuming that this is noncritical and we have to stop somewhere.