Skip to content

Conversation

karenyrx
Copy link
Contributor

Description

Stacked on top of #19447
Implement GRPC Ids, Range, and Terms Set queries

Related Issues

Resolves #18907

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Karen X <karenxyr@gmail.com>
@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Sep 29, 2025
Copy link
Contributor

❌ Gradle check result for 8dbf346: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from 8dbf346 to b7abcfb Compare September 29, 2025 07:27
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from b7abcfb to d89048d Compare September 29, 2025 07:30
Copy link
Contributor

✅ Gradle check result for d89048d: SUCCESS

Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 95.26316% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.86%. Comparing base (28689b7) to head (a44d86c).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...uest/search/query/RangeQueryBuilderProtoUtils.java 93.84% 1 Missing and 7 partials ⚠️
...t/search/query/TermsSetQueryBuilderProtoUtils.java 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19448      +/-   ##
============================================
- Coverage     72.96%   72.86%   -0.11%     
- Complexity    69969    70007      +38     
============================================
  Files          5676     5682       +6     
  Lines        321265   321446     +181     
  Branches      46445    46503      +58     
============================================
- Hits         234407   234212     -195     
- Misses        67901    68316     +415     
+ Partials      18957    18918      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Karen X <karenxyr@gmail.com>
Copy link
Contributor

✅ Gradle check result for d0cbe21: SUCCESS

Copy link
Contributor

✅ Gradle check result for a44d86c: SUCCESS

Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx force-pushed the 0.18.0_bool_ids_range_termsset branch from a44d86c to 08037b3 Compare September 30, 2025 00:48
Signed-off-by: Karen X <karenxyr@gmail.com>
@karenyrx karenyrx marked this pull request as ready for review September 30, 2025 00:50
@karenyrx karenyrx requested a review from a team as a code owner September 30, 2025 00:50
Signed-off-by: Karen X <karenxyr@gmail.com>
Signed-off-by: Karen X <karenxyr@gmail.com>
Copy link
Contributor

❌ Gradle check result for 70eb7b3: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Karen X <karenxyr@gmail.com>
Copy link
Contributor

❌ Gradle check result for 24c230d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] [GRPC][Search] Implement Term-level Query Proto Converters
2 participants