8304811: vmTestbase/vm/mlvm/indy/func/jvmti/stepBreakPopReturn/INDIFY_Test.java fails with JVMTI_ERROR_TYPE_MISMATCH

[alexmenkov]

The change fixes the test which intermittently fails.

The test requests MethodEntry. SingleStep and Breakpoint events globally (from all threads).
MethodEntry handler checks location (to be expected test method);
Breakpoint request specifies location in the testes method, only test threads calls the method;
SingleStep handler has no checks for thread or location. So once SingleStep event is enabled, event from other thread can be posted first (or several events from different threads).
The fix enables SingleStep event only for test thread (we get it in MethodEntry)

testing: tier3

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8304811: vmTestbase/vm/mlvm/indy/func/jvmti/stepBreakPopReturn/INDIFY_Test.java fails with JVMTI_ERROR_TYPE_MISMATCH (Bug - P3)

Reviewers

• Leonid Mesnik (@lmesnik - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27598/head:pull/27598
$ git checkout pull/27598

Update a local copy of the PR:
$ git checkout pull/27598
$ git pull https://git.openjdk.org/jdk.git pull/27598/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27598

View PR using the GUI difftool:
$ git pr show -t 27598

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27598.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304811: vmTestbase/vm/mlvm/indy/func/jvmti/stepBreakPopReturn/INDIFY_Test.java fails with JVMTI_ERROR_TYPE_MISMATCH

Reviewed-by: lmesnik, dholmes, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 5252262: 8292984: Refactor internal container-related interfaces for clarity
• 2c7f738: 8368825: Use switch expression for DateTimeFormatterBuilder pattern character lookup
• 56baf64: 8368520: TLS 1.3 KeyUpdate fails with SunPKCS11 provider
• ... and 8 more: https://git.openjdk.org/jdk/compare/6b72b778039afce0e25986114d15dd29a6786529...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• net
• nio
• security
• serviceability
• shenandoah

[alexmenkov]

/label add serviceability

[openjdk]

@alexmenkov
The serviceability label was successfully added.

[mlbridge]

Webrevs

• 00: Full (2f189dd4)

[lmesnik]

The fix looks reasonable.

[dholmes-ora]

I agree this seems reasonable. Though I still wonder why this suddenly started appearing only on linux-aarch64.

Thanks for the quick fix.

[sspitsyn]

This is good. Thank you for fixing!

[alexmenkov]

Thank you for the review
/integrate

[openjdk]

Going to push as commit 854b384.
Since your change was applied there have been 19 commits pushed to the master branch:

• da7121a: 8366461: Remove obsolete method handle invoke logic
• fa6e884: 8298823: [macos] java/awt/Mouse/EnterExitEvents/DragWindowTest.java continues to fail with "No MouseReleased event on label!"
• 3f27a03: 8368727: CDS custom loader support causes asserts during class unloading
• ... and 16 more: https://git.openjdk.org/jdk/compare/6b72b778039afce0e25986114d15dd29a6786529...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 854b384.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.