Skip to content

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Oct 1, 2025

Fixing a charset en/decoder for x-IBM930. There was a "temporary" mapping for the said code point for the backward compatibility (as of JDK7). Since the issue requests the "correct" mapping, I believe we can replace the temporary one with the correct mapping.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368845: x-IBM930 uses incorrect character for Hex 42 60 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27594/head:pull/27594
$ git checkout pull/27594

Update a local copy of the PR:
$ git checkout pull/27594
$ git pull https://git.openjdk.org/jdk.git pull/27594/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27594

View PR using the GUI difftool:
$ git pr show -t 27594

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27594.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2025

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added build build-dev@openjdk.org i18n i18n-dev@openjdk.org labels Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@naotoj The following labels will be automatically applied to this pull request:

  • build
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2025
@naotoj
Copy link
Member Author

naotoj commented Oct 1, 2025

/label nio-dev

@naotoj
Copy link
Member Author

naotoj commented Oct 1, 2025

/label remove build

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@naotoj
The nio label was successfully added.

@openjdk openjdk bot removed the build build-dev@openjdk.org label Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@naotoj
The build label was successfully removed.

@mlbridge
Copy link

mlbridge bot commented Oct 1, 2025

Webrevs

@justin-curtis-lu
Copy link
Member

Should we add a test to confirm the swap to the new behavior?

@naotoj
Copy link
Member Author

naotoj commented Oct 1, 2025

Should we add a test to confirm the swap to the new behavior?

I had added the test data for the new mapping (Cp930.b2c) which is used for several test cases. Added the bug id to the relevant tests which should make it clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n i18n-dev@openjdk.org nio nio-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants