-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8368845: x-IBM930 uses incorrect character for Hex 42 60 #27594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back naoto! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
/label nio-dev |
/label remove build |
@naotoj |
@naotoj |
Webrevs
|
Should we add a test to confirm the swap to the new behavior? |
I had added the test data for the new mapping (Cp930.b2c) which is used for several test cases. Added the bug id to the relevant tests which should make it clearer. |
Fixing a charset en/decoder for x-IBM930. There was a "temporary" mapping for the said code point for the backward compatibility (as of JDK7). Since the issue requests the "correct" mapping, I believe we can replace the temporary one with the correct mapping.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27594/head:pull/27594
$ git checkout pull/27594
Update a local copy of the PR:
$ git checkout pull/27594
$ git pull https://git.openjdk.org/jdk.git pull/27594/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27594
View PR using the GUI difftool:
$ git pr show -t 27594
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27594.diff
Using Webrev
Link to Webrev Comment