8368698: runtime/cds/appcds/aotCache/OldClassSupport.java assert(can_add()) failed: Cannot add TrainingData objects

[veresov]

That's a bit of a bug trail from JDK-8366948. We need to check if the TD snapshot has happened before attempting to modify the data.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8368698: runtime/cds/appcds/aotCache/OldClassSupport.java assert(can_add()) failed: Cannot add TrainingData objects (Bug - P4)

Reviewers

• Dan Heidinga (@DanHeidinga - no project role)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27593/head:pull/27593
$ git checkout pull/27593

Update a local copy of the PR:
$ git checkout pull/27593
$ git pull https://git.openjdk.org/jdk.git pull/27593/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27593

View PR using the GUI difftool:
$ git pr show -t 27593

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27593.diff

Using Webrev

Link to Webrev Comment

[veresov]

/label add hotspot-compiler

[bridgekeeper]

👋 Welcome back iveresov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@veresov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368698: runtime/cds/appcds/aotCache/OldClassSupport.java assert(can_add()) failed: Cannot add TrainingData objects

Reviewed-by: heidinga, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• db6320d: 8368968: FloatingDecimal: Clean up unused code
• ef724f4: 8368985: Small Float16 refactorings

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@veresov
The hotspot-compiler label was successfully added.

[openjdk]

@veresov The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (57a796b7)

[DanHeidinga]

lgtm

[iklam]

LGTM

[veresov]

/integrate

[openjdk]

Going to push as commit 4df41d2.
Since your change was applied there have been 2 commits pushed to the master branch:

• db6320d: 8368968: FloatingDecimal: Clean up unused code
• ef724f4: 8368985: Small Float16 refactorings

Your commit was automatically rebased without conflicts.

[openjdk]

@veresov Pushed as commit 4df41d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[veresov]

/backport jdk25u

[openjdk]

@veresov the backport was successfully created on the branch backport-veresov-4df41d2a-master in my personal fork of openjdk/jdk25u. To create a pull request with this backport targeting openjdk/jdk25u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 4df41d2a from the openjdk/jdk repository.

The commit being backported was authored by Igor Veresov on 1 Oct 2025 and was reviewed by Dan Heidinga and Ioi Lam.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u:

$ git fetch https://github.com/openjdk-bots/jdk25u.git backport-veresov-4df41d2a-master:backport-veresov-4df41d2a-master
$ git checkout backport-veresov-4df41d2a-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk25u.git backport-veresov-4df41d2a-master