Skip to content

Conversation

JoKern65
Copy link
Contributor

@JoKern65 JoKern65 commented Oct 1, 2025

In _SafeFetchXX_internal() a pointer is checked for readability before using. It returns false if this is not the case. The implementation tries to read from the pointer if this is not feasible the signal handler comes into place jumping back to the function via longjmp, so the _SafeFetchXX_internal() itself can return with a false and a null as pseudo content of the address. If the address was readable the function returns true and provides the content of the address.
Because AIX allows reading from address zero, _SafeFetchXX_internal() returns true and follow up functions using the address are called. All these functions end up in an UBSAN finding regarding reading from zero.
The solution could be to manually code that also AIX behaves like other operating systems and returns false and the content zero in case of address zero. Then no UBSAN finding occur.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368997: AIX allows reading from address zero which leads to several ubsan findings (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27591/head:pull/27591
$ git checkout pull/27591

Update a local copy of the PR:
$ git checkout pull/27591
$ git pull https://git.openjdk.org/jdk.git pull/27591/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27591

View PR using the GUI difftool:
$ git pr show -t 27591

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27591.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2025

👋 Welcome back jkern! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8368997: AIX allows reading from address zero which leads to several ubsan findings 8368997: AIX allows reading from address zero which leads to several ubsan findings Oct 1, 2025
@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@JoKern65 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant