8368877: Generate Jextract bindings for Kqueue #27590
Conversation
… how they were genereated
…in copyright header
|
👋 Welcome back dclarke! A progress list of the required criteria for merging this PR into |
|
@DarraghClarke This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 125 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@DarraghClarke The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
| * echo "#include <sys/event.h>" >> $HEADER_NAME | ||
| * | ||
| * | ||
| * jextract --target-package jdk.internal.natives.net.kqueue \ |
There was a problem hiding this comment.
Should the target package be jdk.internal.ffi.generated.kqueue?
This PR is based on #25546 , though it was suggested to split that PR into 2 for easier reviewing and to give better visibility in the git history.
This PR contains all the JExtract generated code that will be needed for converting Java's KQueue implementation to use Panama features instead of JNI. The actual updates to KQueue to make use of these files will come in the second PR.
The basic structure here has the different native structures and methods split into 3 different packages all preceded by
src/java.base/macosx/classes/jdk/internal/ffi/generated/Included in each package is a file
package-info.javawhich contains the script that was used to generate these files so that others can reproduce them in future.The only modifications that have been made to the files post-generation are:
Some further modifications to these files to cut down on code duplication and adding support for errno handling on the native calls will come in the 2nd PR alongside the KQueue changes mentioned.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27590/head:pull/27590$ git checkout pull/27590Update a local copy of the PR:
$ git checkout pull/27590$ git pull https://git.openjdk.org/jdk.git pull/27590/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27590View PR using the GUI difftool:
$ git pr show -t 27590Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27590.diff
Using Webrev
Link to Webrev Comment