-
Notifications
You must be signed in to change notification settings - Fork 6.3k
8333727: Use JOpt in jpackage to parse command line #27564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
8333727: Use JOpt in jpackage to parse command line #27564
Conversation
👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@alexeysemenyukoracle The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
b41135c
to
7b80329
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
7b80329
to
0cd5595
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
0cd5595
to
6a0f15c
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
6a0f15c
to
20137ae
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
20137ae
to
c299be6
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
…l with the model classes
…ix PackagingPipeline, *Bundler and StandardBundlerParam.getDefaultAppVersion accordingly
…ObjectMapper in tests. Change signature of AppImageFile.load(Path appImageDir, ApplicationLayout appLayout) to AppImageFile.load(ApplicationLayout appLayout), appImageDir parameter is redundant.
…erationDescriptor. Rework BundlingEnvironment.
…and options; copy ObjectMapper from test/jdk/tools/jpackage/helpers/jdk/jpackage/test/ObjectMapper.java
…ApplicationBuilder
…Resources.properties: remove unused IDs
c299be6
to
b3be7ff
Compare
@alexeysemenyukoracle Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
Use "JOpt Simple" from jdk.internal.joptsimple package to parse jpackage command line.
All command-line parsing code is placed in a new "jdk.jpackage.internal.cli" package with 89% unit test coverage.
Error reporting improved:
Errors in launcher property files contain the path of the property file.
Not the first, but all command-line errors are reported.
All "params"-specific code removed.
Old tool provider implementation jdk.jpackage.internal.JPackageToolProvider had lousy thread-safety protection that didn't work when multiple instances of jpackage tool provider are created and invoked asynchronously. This patch fixes this issue. It is safe to invoke the same jpackage tool provider instance asynchronously, and also safe to invoke multiple instances of jpackage tool provider.
Autogenerated summary of all recognized options (jdk/test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/cli/jpackage-options.md).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27564/head:pull/27564
$ git checkout pull/27564
Update a local copy of the PR:
$ git checkout pull/27564
$ git pull https://git.openjdk.org/jdk.git pull/27564/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 27564
View PR using the GUI difftool:
$ git pr show -t 27564
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27564.diff