[IMP] booking_engine: city tax widget #1215
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
abdrahmanrashed
commented
Oct 10, 2025
abdrahmanrashed
commented
- Add a widget to help user to compute the number of city tax computation to be delivered .
- Adjust the "Check guests out" knowledge section with below input in the dependent industries.
|
|
abdrahmanrashed
force-pushed
the
19.0-booking-engine-city-tax-aras
branch
7 times, most recently
from
e1aecba to
34151c3
Compare
abdrahmanrashed
force-pushed
the
19.0-booking-engine-city-tax-aras
branch
2 times, most recently
from
ba7803f to
2423e7f
Compare
- Add a widget to help user to compute the number of city tax computation to be delivered . - Adjust the "Check guests out" knowledge section with below input in the dependent industries.
abdrahmanrashed
force-pushed
the
19.0-booking-engine-city-tax-aras
branch
from
2423e7f to
2651cb5
Compare
vava-odoo
requested changes
Oct 22, 2025
| ], | ||
| 'data': [ | ||
| 'data/res_config_settings.xml', | ||
| 'data/ir_model.xml', |
There was a problem hiding this comment.
could you bump the version, please
| for slot in record.sale_line_id.planning_slot_ids: | ||
| if slot.start_datetime and slot.end_datetime: | ||
| nights += ceil((slot.end_datetime - slot.start_datetime).total_seconds() / (24 * 3600)) | ||
| if record.sale_line_id and record.sale_line_id.planning_slot_ids: |
There was a problem hiding this comment.
ORM would return False (and not fail) if there is no record.sale_line_id
Suggested change
| if record.sale_line_id and record.sale_line_id.planning_slot_ids: | |
| if record.sale_line_id.planning_slot_ids: |
Comment on lines
+85
to
+90
| start = rental_start_date.replace(hour=int(pickup_time), minute=int(pickup_time % 1 * 60), second=0) | ||
| record['rental_start_date'] = start.astimezone(tz=dateutil.tz.UTC).replace(tzinfo=None) | ||
| rental_return_date = record.rental_return_date.astimezone(tz=dateutil.tz.gettz(tz)) | ||
| start = rental_start_date.replace(hour=int(pickup_time), minute=int(pickup_time % 1 * 60), second=0, microsecond=0) | ||
| start_datetime = start.astimezone(tz=dateutil.tz.UTC) | ||
| record['rental_start_date'] = start_datetime.replace(tzinfo=None) | ||
| end = rental_return_date.replace(hour=int(return_time), minute=int(return_time % 1 * 60), second=0, microsecond=0) | ||
| end_datetime = end.astimezone(tz=dateutil.tz.UTC) | ||
| record['rental_return_date'] = end_datetime.replace(tzinfo=None) | ||
| end = rental_return_date.replace(hour=int(return_time), minute=int(return_time % 1 * 60), second=0) | ||
| record['rental_return_date'] = end.astimezone(tz=dateutil.tz.UTC).replace(tzinfo=None) |
There was a problem hiding this comment.
this looks like a useless diff
Comment on lines
+57
to
+64
| <field name="compute"><![CDATA[ | ||
| for record in self: | ||
| if not record.x_nationality and not record.x_document_type and not record.x_document_number: | ||
| record['x_identity_check'] = 'na' | ||
| elif record.x_nationality and record.x_document_type and record.x_document_number: | ||
| record['x_identity_check'] = 'ok' | ||
| else: record['x_identity_check'] = 'invalid' | ||
| ]]></field> |
There was a problem hiding this comment.
useless (and wrong) diff
Comment on lines
+116
to
+117
| <field name="compute"><![CDATA[ | ||
| for record in self: |
There was a problem hiding this comment.
avoid useless diff like this one please
| <ul> | ||
| <li>Open your guest order from the Guest House App.</li> | ||
| <li>Click the Check out button to capture they return you the keys.</li> | ||
| <li>Check and adjust if needed the number of guest who stayed in each room. Then confirm the number of city tax to be charged, which updated the delivered city tax count.</li> |
There was a problem hiding this comment.
Suggested change
| <li>Check and adjust if needed the number of guest who stayed in each room. Then confirm the number of city tax to be charged, which updated the delivered city tax count.</li> | |
| <li>Check and adjust if needed the number of guests who stayed in each room. Then confirm the number of city taxes to be charged, which updates the delivered city tax count.</li> |
| <p>Example: A room for 2 is booked for 4 nights, two guest were here for the first | ||
| three night but onlu one stayed the last night. Then the guest x nights is | ||
| 2x3+1x1=7.</p> | ||
| <div class="o-paragraph">City Tax are to be billed to spent nights in practice and not in theory and are counted in number of guest night. </div> |
There was a problem hiding this comment.
Suggested change
| <div class="o-paragraph">City Tax are to be billed to spent nights in practice and not in theory and are counted in number of guest night. </div> | |
| <div class="o-paragraph">City Taxes are to be billed to spent nights in practice and not in theory and are counted in number of guest nights. </div> |
| three night but onlu one stayed the last night. Then the guest x nights is | ||
| 2x3+1x1=7.</p> | ||
| <div class="o-paragraph">City Tax are to be billed to spent nights in practice and not in theory and are counted in number of guest night. </div> | ||
| <div class="o-paragraph">Example: A room for 2 is booked for 4 nights, two guest were here for the first three night but only one stayed the last night. Then the guest x nights is 2x3+1x1=7.</div> |
There was a problem hiding this comment.
Suggested change
| <div class="o-paragraph">Example: A room for 2 is booked for 4 nights, two guest were here for the first three night but only one stayed the last night. Then the guest x nights is 2x3+1x1=7.</div> | |
| <div class="o-paragraph">Example: A room for 2 is booked for 4 nights, two guests were here for the first three nights but only one stayed the last night. Then the guest x nights is 2x3+1x1=7.</div> |
| <ul> | ||
| <li>Open your guest order from the Holiday House App.</li> | ||
| <li>Click the Check out button to capture they return you the keys.</li> | ||
| <li>Check and adjust if needed the number of guest who stayed in each room. Then confirm the number of city tax to be charged, which updated the delivered city tax count.</li> |
There was a problem hiding this comment.
same comments for all knowledge
Comment on lines
-24
to
-33
| 'data/views.xml', | ||
| 'data/product_pricing.xml', | ||
| 'data/views.xml', | ||
| ], | ||
| 'demo': [ | ||
| 'demo/hr_employee.xml', | ||
| 'demo/ir_attachment_post.xml', | ||
| 'demo/product_template_post.xml', | ||
| 'demo/pos_config.xml', | ||
| 'demo/product_attribute.xml', | ||
| 'demo/rating_rating.xml', | ||
| 'demo/ir_attachment_post.xml', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.