feat: Add new ON_HOLD status type #3650
Conversation
Co-Authored-By: Maarten den Braber <m@mdbraber.com>
See obsidian-tasks-group#3636 Co-Authored-By: Maarten den Braber <m@mdbraber.com>
See obsidian-tasks-group#3636 Co-Authored-By: Maarten den Braber <m@mdbraber.com>
Co-Authored-By: Maarten den Braber <m@mdbraber.com>
Co-Authored-By: Maarten den Braber <m@mdbraber.com>
Co-Authored-By: Maarten den Braber <m@mdbraber.com>
claremacrae
changed the title
… a `??` expression.' SonarQube output: Binary expressions should not always return the same value typescript:S6638
| - It is `TODO`, `IN_PROGRESS` or `ON_HOLD`. | ||
| - And any of the tasks that **directly depend on it** are also `TODO`, `IN_PROGRESS` or `ON_HOLD`. |
There was a problem hiding this comment.
We must make sure that there are tests of all the statements below about how ON_HOLD interacts with blocking/blocked.
I am presuming it behaves the same as for TODO and IN_PROGRESS but have not yet tested it.
There was a problem hiding this comment.
Searching for the following regex throughout the whole repo shows a number of areas not yet considered:
(TODO|IN_PROGRESS|ON_HOLD|DONE|CANCELLED|NON_TASK)
- There references in the docs to things like
If that next status is neitherTODOnorIN_PROGRESS``- `When DONE is not followed by TODO or IN_PROGRESS
- There are translation strings that need checking and maybe updating:
-
|
I've edited this PR so that it seeks to merge in to That would have happened because this PR was created from a branch off of the work we did last week on my machine.... |
|
2 participants
Types of changes
Changes visible to users:
feat- non-breaking change which adds functionality)docs- improvements to any documentation content for users)vault- improvements to the Tasks-Demo sample vault)Internal changes:
test- additions and improvements to unit tests and the smoke tests)Description
Add new ON_HOLD status type
Motivation and Context
Fixes #3636
How has this been tested?
Automated tests and exploratory testing the test vault
Screenshots (if appropriate)
Checklist
yarn run lint.Terms