Skip to content

Conversation

saquibkhan
Copy link
Contributor

@saquibkhan saquibkhan commented Oct 8, 2025

updated 2fa related docs removing totp refs

References

@saquibkhan saquibkhan requested review from a team and leobalter as code owners October 8, 2025 23:22
@saquibkhan saquibkhan changed the title updated 2fa related docs deremoving totp refs updated 2fa related docs removing totp refs Oct 8, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note (no need to change in this PR): in a future it would be ideal to just remove this extra step as it's now an assertion rather than an option.

Copy link
Contributor Author

@saquibkhan saquibkhan Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are correct ,now this 2fa method doesn't make any sense and we can take user directly to configure screen. i'll add a note could be a future task to also make respective change in the UI

Edit; Added a note here - https://github.com/github/npm/issues/14221#issuecomment-3387848940

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may want to remove this file. You can have .DS_Store in your ignore settings.

saquibkhan and others added 5 commits October 9, 2025 20:00
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
@saquibkhan
Copy link
Contributor Author

@leobalter thanks for the review comments, i think i addressed all your comments, requesting another round of review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants