-
Notifications
You must be signed in to change notification settings - Fork 3.4k
updated 2fa related docs removing totp refs #1740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cb62174
to
f3d46a7
Compare
...t/getting-started/setting-up-your-npm-user-account/configuring-two-factor-authentication.mdx
Outdated
Show resolved
Hide resolved
...t/getting-started/setting-up-your-npm-user-account/configuring-two-factor-authentication.mdx
Outdated
Show resolved
Hide resolved
...t/getting-started/setting-up-your-npm-user-account/configuring-two-factor-authentication.mdx
Outdated
Show resolved
Hide resolved
...t/getting-started/setting-up-your-npm-user-account/configuring-two-factor-authentication.mdx
Outdated
Show resolved
Hide resolved
...ent/getting-started/setting-up-your-npm-user-account/recovering-your-2fa-enabled-account.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note (no need to change in this PR): in a future it would be ideal to just remove this extra step as it's now an assertion rather than an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are correct ,now this 2fa method doesn't make any sense and we can take user directly to configure screen. i'll add a note could be a future task to also make respective change in the UI
Edit; Added a note here - https://github.com/github/npm/issues/14221#issuecomment-3387848940
static/getting-started/.DS_Store
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may want to remove this file. You can have .DS_Store in your ignore settings.
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
Co-authored-by: Leo Balter <301201+leobalter@users.noreply.github.com>
@leobalter thanks for the review comments, i think i addressed all your comments, requesting another round of review |
updated 2fa related docs removing totp refs
References