Skip to content

Conversation

trueNAHO
Copy link
Member

@trueNAHO trueNAHO commented Sep 29, 2025

Lock the base16-fish input to a custom patch [2] ("Make autosuggestion
and comment base03"), since it is currently impossible to apply patches
to flake inputs [1] ("Support flake references to patches").

Once this single-patch approach no longer scales, the repository should
be properly forked, if [2] has still not been merged.

[1]: https://github.com/NixOS/nix/issues/3920
[2]: https://github.com/tomyun/base16-fish/pull/12

Closes: https://github.com/nix-community/stylix/issues/1730

Might be worth testing this PR with several themes to see if it really improves the situation.

CC: @NovaViper, @gaykitty


@trueNAHO trueNAHO added the backport: release-25.05 Changes to release-25.05 stable branch label Sep 29, 2025
@stylix-automation stylix-automation bot added topic: dependencies Dependency updates topic: flake /flake.nix, /flake.lock, and /flake/ subsystems labels Sep 29, 2025
Lock the base16-fish input to a custom patch [2] ("Make autosuggestion
and comment base03"), since it is currently impossible to apply patches
to flake inputs [1] ("Support flake references to patches").

Once this single-patch approach no longer scales, the repository should
be properly forked, if [2] has still not been merged.

[1]: NixOS/nix#3920
[2]: tomyun/base16-fish#12

Closes: nix-community#1730
@trueNAHO trueNAHO force-pushed the flake-lock-base16-fish-input-to-custom-patch branch from 4c1a9ef to 6870a54 Compare September 29, 2025 18:49
@NovaViper
Copy link

It didn't seem to make a difference on my side sadly 😭

@trueNAHO
Copy link
Member Author

It didn't seem to make a difference on my side sadly 😭

I did not actually test this yet with several themes, but the patch should at least have been pulled, as the inputs.base16-fish.outPath tree seems to be the correct one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport: release-25.05 Changes to release-25.05 stable branch topic: dependencies Dependency updates topic: flake /flake.nix, /flake.lock, and /flake/ subsystems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants