Skip to content

Conversation

FlorentinD
Copy link
Collaborator

@FlorentinD FlorentinD commented Sep 12, 2025

No description provided.

@FlorentinD FlorentinD requested a review from adamnsch September 12, 2025 10:56
Copy link
Collaborator

@adamnsch adamnsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me! It does change how the library is used. Is it the same for the other constructors, or just this one?

@FlorentinD
Copy link
Collaborator Author

FlorentinD commented Sep 26, 2025

behaviours to discuss:

(1) default sizing -- node: {size: "foo"} -- this fails right now for invalid size option. How can the user circumvent this if they dont have an actual property to use for the size.
(2) sizing property=mySize -- node {size: 1, mySize: 42} -- i think right now there is a bug which will lead to size: 1 taking precedence over mySize (this needs to be fixed)

In general its difficult inside a cypher query to rename the properties of your node/rel to fit our expected schema / avoid type conflicts

@FlorentinD FlorentinD requested a review from a team as a code owner September 30, 2025 13:02
@FlorentinD FlorentinD merged commit eee3e80 into main Sep 30, 2025
10 checks passed
@FlorentinD FlorentinD deleted the fix-default-size-caption-from-neo4j branch September 30, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants