feat: migrate to gradle #294
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbiville
reviewed
Sep 22, 2025
core/build.gradle.kts
Outdated
|
|
||
| java { | ||
| withJavadocJar() | ||
| sourceCompatibility = JavaVersion.VERSION_17 |
There was a problem hiding this comment.
It should be version 11 in theory
it was needed by the Dataflow template back then but the Dataflow template now builds with a JDK 17.
The Spark connector (where we might add support for the spec) is currently on JDK 8, but Spark 4 support means we'll move to JDK 17 soon.
The Kafka connector is on JDK 11, but I don't think we have any plans to add import-spec there.
GregHib
force-pushed
the
gradle
branch
3 times, most recently
from
1dffb22 to
ce03018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step in working towards a kotlin multi-platform library is changing maven for gradle and KMP is only supported by gradle.
Note formatting is a bit annoying due to diffplug/spotless#2625