Fix CanFdMessage64 #1
Conversation
Signed-off-by: Tobias Lorenz <tobias.lorenz@gmx.net>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the CanFdMessage64 implementation by updating tests, improving type safety in examples, and modifying data storage.
- Updated expected validDataBytes value in tests
- Modified Parser.cpp to use explicit type casting for channel
- Changed CanFdMessage64 data storage from a fixed array to a vector and updated associated I/O operations
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Vector/BLF/tests/unittests/test_CanFdMessage64.cpp | Updated test expected value for validDataBytes |
| src/Vector/BLF/docs/examples/Parser.cpp | Added explicit static cast and a default branch in the channel printout example |
| src/Vector/BLF/CanFdMessage64.h | Changed data storage from std::array to std::vector |
| src/Vector/BLF/CanFdMessage64.cpp | Added resize of data based on validDataBytes and updated write() pre-processing |
| CHANGELOG.md | Documented the fix in the changelog |
Comments suppressed due to low confidence (1)
src/Vector/BLF/tests/unittests/test_CanFdMessage64.cpp:38
- Verify that the updated expected validDataBytes value (0x40) fully aligns with the new specifications for CanFdMessage64.
BOOST_CHECK_EQUAL(obj->validDataBytes, 0x40);
| * dlc). | ||
| */ | ||
| std::array<BYTE, 64> data; | ||
| std::vector<uint8_t> data; |
There was a problem hiding this comment.
Switching from a fixed-size std::array to a dynamic std::vector alters memory allocation. Consider documenting the rationale for this change and evaluating potential performance impacts if data is always 64 bytes.
Copilot uses AI. Check for mistakes.
| void CanFdMessage64::write(AbstractFile & os) | ||
| { | ||
| /* pre processing */ | ||
| validDataBytes = static_cast<WORD>(data.size()); |
There was a problem hiding this comment.
Casting data.size() to WORD may lead to overflow if data.size() ever exceeds WORD's maximum value. Consider adding a check or enforcing an upper bound.
Copilot uses AI. Check for mistakes.
2 participants
No description provided.