fix: React Bootstrap un-revert with fixups #8996

camd · 2025-09-26T04:04:29Z

I have gone over Treeherder, perfherder, Intermittent Failures View and Push Health. They all look good to me. But there is a lot, so I may have missed something.

codecov-commenter · 2025-10-06T17:11:39Z

Codecov Report

❌ Patch coverage is 57.71971% with 178 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.51%. Comparing base (e5a02d3) to head (5280e51).

Files with missing lines	Patch %	Lines
...i/job-view/details/shared/ResponsiveNavigation.jsx	0.00%	58 Missing ⚠️
ui/job-view/details/tabs/TabsPanel.jsx	72.80%	34 Missing ⚠️
ui/push-health/ClassificationGroup.jsx	41.17%	10 Missing ⚠️
ui/shared/BugFiler.jsx	52.63%	9 Missing ⚠️
ui/infra-compare/InfraCompareTableRow.jsx	0.00%	8 Missing ⚠️
ui/push-health/Test.jsx	20.00%	8 Missing ⚠️
ui/perfherder/alerts/StatusDropdown.jsx	40.00%	6 Missing ⚠️
ui/job-view/pushes/Push.jsx	42.85%	3 Missing and 1 partial ⚠️
ui/perfherder/shared/Pagination.jsx	55.55%	4 Missing ⚠️
ui/perfherder/compare/SelectorCard.jsx	72.72%	3 Missing ⚠️
... and 25 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8996      +/-   ##
==========================================
- Coverage   77.73%   77.51%   -0.22%     
==========================================
  Files         581      582       +1     
  Lines       29710    29876     +166     
  Branches     3585     3662      +77     
==========================================
+ Hits        23095    23159      +64     
- Misses       6450     6550     +100     
- Partials      165      167       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

beatrice-acasandrei · 2025-10-07T13:22:15Z

ui/perfherder/graphs/LegendCard.jsx

 import React from 'react';
 import PropTypes from 'prop-types';
-import { Badge, Button, FormGroup, Input } from 'reactstrap';
+import { Badge, Button, Form } from 'react-bootstrap';


Locally I see some issues with this component.

beatrice-acasandrei · 2025-10-07T13:28:12Z

treeherder-comparison-analysis.md

+
+## Overview
+
+This document tracks differences found between the local development version of Treeherder (<http://localhost:5001>) and the staging version (<https://treeherder.allizom.org>) when comparing the Perfherder interface.


Logging in locally is no longer working for http://localhost:5001/

I switched everything back to 5000.

Archaeopteryx · 2025-10-09T20:21:43Z

Some observations:

All the links are underscored. Can we get the former behavior back? That's a change in bootstrap v5.
The login was not working. The latest commit added to this branch allows to log in but still shows an error for Taskcluster because the new client needs to be allowed and the PR for that is still pending review.
In the toolbar at the top while logged in, the bell icon has a dropdown which is not available without the patch - only one options should be available.

…ndering issues with dropdowns and bugfiler (#8988) This reverts commit b1faecc.

camd · 2025-10-10T22:08:33Z

Some observations:

1. All the links are underscored. Can we get the former behavior back? That's a change in bootstrap v5.

2. The login was not working. The latest commit added [to this branch](https://github.com/Archaeopteryx/treeherder/tree/campd-reactStrap-2) allows to log in but still shows an error for Taskcluster because the new client needs to be allowed and the PR for that is still pending review.

3. In the toolbar at the top while logged in, the bell icon has a dropdown which is not available without the patch - only one options should be available.

I've fixed all these issues. I was able to log in locally via LDAP.

Archaeopteryx · 2025-10-18T00:50:55Z

font size
- Top toolbar decreased in size, please keep the previous size (this applies to all main views: TH, PH, IFV
- Secondary toolbar: The colored filter buttons have decreased and should have the old size.
- Revisions and bug numbers for the commits in the push view have a larger font size now which is different from the size for the plain text commit message. Please decrease the link size to get the old one back.
- Failure suggestion: The failure line's Filter and Log buttons have increased but should have kept the size. Impression is some buttons didn't increase here.
- Failure suggestion: Suggested bugs (not internal issues): They are links and their size increased, it should be same one like before and identical to the one of the failure line.
- Bottom left with a failed task selected which has been classified with a bug: Bug number is shown as link, should use the same font size like the two lines below.
style
- If the filter button in the secondary toolbar is clicked, the content is stretch vertically across 3 lines now: filter type, filter value and action button. They should be in one line. (Missing attribute to force inline behavior?)
- Bottom left, ... actions menu: Inspect Task should be aligned like the other menu options
- Bottom left: Can the toolbar buttons be vertically centered again?
- With a failed bug, failure lines and bug suggestions both open and closed, a Show more bug suggestions button is shown. It lost its thin black border. Please restore it.
- With a failed bug, failure lines and bug suggestions both open and closed, a Show more bug suggestions button is shown. Please remove the link underline.
- If a task gets added to the pinboard (Ctrl/Cmd + Click or press Space while selected), the pinboard gets opened (expected) and the area with the bug suggestions squeezed into a small vertical band because a white area gets added below.
- Logviewer: The failure line numbers at the top right are white on white, should be more white on grey like before.
- While logged in: User menu is missing dropdown indicator.
- Bugfiler: Input fields have too large vertical height.

* Bugfiler: `Summary` field should run to the right up to the toggle and character count. * Commit list: Bug links: Tooltip should be wider. Its width has been reduced and needs many vertical lines now. * Perfherder: Default view has checkboxes as rectangles now (top left of each box) * Perfherder: Default view: Please keep the test names left aligned, they are centered now.

Once this content got replaced with this error when the pinboard got emptied of tasks and bug numbers and an attempt was made to close it.

Uncaught runtime errors:
ERROR
The operation was aborted. 
DetailsPanel/this.selectJob/<@webpack-internal:///./ui/job-view/details/DetailsPanel.jsx:132:36
callCallback@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:15036:12
commitUpdateQueue@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:15057:21
commitLayoutEffectOnFiber@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:23398:30
commitLayoutMountEffects_complete@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:24722:34
commitLayoutEffects_begin@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:24708:40
commitLayoutEffects_begin@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:24690:36
commitLayoutEffects@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:24646:28
commitRootImpl@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26857:24
commitRoot@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26716:19
performSyncWorkOnRoot@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:26151:13
flushSyncCallbacks@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:12042:22
ensureRootIsScheduled/<@webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:25685:13

camd self-assigned this Sep 26, 2025

camd force-pushed the camd/react-bootstrap-fixups branch from b3c6aa6 to e75521b Compare September 26, 2025 04:05

camd force-pushed the camd/react-bootstrap-fixups branch 4 times, most recently from a93f2cf to 90e3965 Compare October 5, 2025 16:54

camd marked this pull request as ready for review October 6, 2025 14:59

camd requested review from beatrice-acasandrei and esanuandra as code owners October 6, 2025 14:59

camd force-pushed the camd/react-bootstrap-fixups branch 2 times, most recently from b5072a5 to 8eba2f1 Compare October 6, 2025 16:58

beatrice-acasandrei reviewed Oct 7, 2025

View reviewed changes

camd force-pushed the camd/react-bootstrap-fixups branch from 8eba2f1 to 87b9115 Compare October 8, 2025 20:50

camd added 6 commits October 10, 2025 14:27

Reapply "migrate reactstrap to react bootstrap (#8897)" because of re…

c26e0d9

…ndering issues with dropdowns and bugfiler (#8988) This reverts commit b1faecc.

fix: Dropdowns for elipsis and CustomMenuActions dropdowns

4bc9d0d

fix: Bugfiler and tier toggles

2c90d1b

fix Bootstrap bugs

782536e

fixes for dropdowns

cb256cf

intermittent failure view fixes

f4030cc

camd force-pushed the camd/react-bootstrap-fixups branch 2 times, most recently from 7df71c4 to 9137c33 Compare October 10, 2025 22:08

fixes to perfherder and links

5280e51

camd force-pushed the camd/react-bootstrap-fixups branch from 9137c33 to 5280e51 Compare October 13, 2025 17:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: React Bootstrap un-revert with fixups #8996

fix: React Bootstrap un-revert with fixups #8996

Uh oh!

camd commented Sep 26, 2025 •

edited

Loading

Uh oh!

codecov-commenter commented Oct 6, 2025 •

edited

Loading

Uh oh!

beatrice-acasandrei Oct 7, 2025 •

edited

Loading

Uh oh!

camd Oct 10, 2025

Uh oh!

beatrice-acasandrei Oct 7, 2025

Uh oh!

camd Oct 10, 2025

Uh oh!

Archaeopteryx commented Oct 9, 2025

Uh oh!

camd commented Oct 10, 2025

Uh oh!

Archaeopteryx commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants


		## Overview

		This document tracks differences found between the local development version of Treeherder (<http://localhost:5001>) and the staging version (<https://treeherder.allizom.org>) when comparing the Perfherder interface.

fix: React Bootstrap un-revert with fixups #8996

Are you sure you want to change the base?

fix: React Bootstrap un-revert with fixups #8996

Uh oh!

Conversation

camd commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

beatrice-acasandrei Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camd Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

beatrice-acasandrei Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

camd Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Archaeopteryx commented Oct 9, 2025

Uh oh!

camd commented Oct 10, 2025

Uh oh!

Archaeopteryx commented Oct 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

camd commented Sep 26, 2025 •

edited

Loading

codecov-commenter commented Oct 6, 2025 •

edited

Loading

beatrice-acasandrei Oct 7, 2025 •

edited

Loading