Skip to content

Conversation

rozza
Copy link
Member

@rozza rozza commented Oct 9, 2025

Moved specifications submodule out of driver-core into a testing directory.
Deleted old copy of bson specification tests and updated to use the submodule
Fixed Json output for positive exponents to match the the extended json specification

Added test exceptions to BinaryVectorGenericBsonTest
Added BsonBinaryVector prose tests
Added extra regression tests to ensure both explicit and implicit doubles with positive exponets parse as expected.

JAVA-5877
JAVA-5779
JAVA-5782
JAVA-5652

@rozza rozza requested a review from vbabanin October 9, 2025 10:51
@rozza rozza requested a review from a team as a code owner October 9, 2025 10:51
@rozza rozza requested a review from Copilot October 9, 2025 10:51
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reorganizes specification testing by moving the MongoDB specifications submodule from driver-core to a shared testing directory, updates JSON output for positive exponents to match the extended JSON specification, and adds comprehensive testing for BsonBinaryVector functionality.

  • Moved specifications submodule from driver-core to shared testing directory for better organization
  • Fixed JSON output to include explicit "+" signs for positive exponents in extended JSON
  • Added comprehensive testing for BsonBinaryVector including prose tests and enhanced validation

Reviewed Changes

Copilot reviewed 47 out of 49 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.gitmodules Updated submodule path from driver-core to testing directory
bson/build.gradle.kts Added test resource processing to include shared testing resources
driver-core/build.gradle.kts Added test resource processing to include shared testing resources
bson/src/main/org/bson/json/*.java Modified double converters to use consistent JSON formatting with explicit positive exponents
bson/src/main/org/bson/BinaryVector.java Added validation logging for non-zero padding bits
bson/src/test/unit/org/bson/vector/BinaryVectorGenericBsonTest.java Enhanced test coverage and updated to use new spec test location
bson/src/test/unit/org/bson/*.java Updated test references to use new specification test helper method
bson/src/test/resources/bson*/ Removed old BSON specification test files (now using submodule)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Moved specifications submodule out of driver-core into a testing directory.
Deleted old copy of bson specification tests and updated to use the submodule
Fixed Json output for positive exponents to match the the extended json specification

Added test exceptions to BinaryVectorGenericBsonTest
Added BsonBinaryVector prose tests
Added extra regression tests to ensure both explicit and implicit doubles with positive exponets parse as expected.

JAVA-5877
JAVA-5779
JAVA-5782
JAVA-5652
rozza and others added 2 commits October 9, 2025 11:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant