-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add support for awaitMinPoolSize in unified test runner. #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
putEntity(id, mongoClientSupplier.apply(clientSettings), clients); | ||
if (waitForMinPoolSizeToPopulate) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seem to be hitting a number of timeouts in evergreen.
Is it worth reducing the chance of this by moving this after the waitForPoolAsyncWorkManagerStart
logic? Or always waiting for the waitForPoolAsyncWorkManagerStart
before waiting for min pool size?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The timeouts were caused by a non–spec-compliant unified test in the specification repo. I added a code comment and ignored these tests in UnifiedTestModifications
, after confirming with the author that they should be fixed upstream.
In any case, I agree that waitForPoolAsyncWorkManagerStart
should come first, so I’ve moved it accordingly.
} | ||
} | ||
|
||
public void clearEvents() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this isn't used and can be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, I accidentally marked this as ready for review. it was meant to stay in draft to run the tests with clearing events and not clearing events. I removed those unused methods and added a code comment why we are not clearing events. Thanks!
} | ||
} | ||
|
||
public synchronized void clearMessages() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this isn't used and can be reverted
// testConnectionPoolListener.clearEvents(); | ||
// getClientLoggingInterceptor(id).clearMessages(); | ||
} catch (TimeoutException | InterruptedException e) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// testConnectionPoolListener.clearEvents(); | |
// getClientLoggingInterceptor(id).clearMessages(); | |
} catch (TimeoutException | InterruptedException e) { | |
} catch (TimeoutException | InterruptedException e) { |
JAVA-5957