Skip to content

Conversation

vbabanin
Copy link
Member

@vbabanin vbabanin commented Oct 9, 2025

@vbabanin vbabanin requested a review from a team as a code owner October 9, 2025 03:00
@vbabanin vbabanin requested review from rozza and removed request for a team October 9, 2025 03:00
}

putEntity(id, mongoClientSupplier.apply(clientSettings), clients);
if (waitForMinPoolSizeToPopulate) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to be hitting a number of timeouts in evergreen.

Is it worth reducing the chance of this by moving this after the waitForPoolAsyncWorkManagerStart logic? Or always waiting for the waitForPoolAsyncWorkManagerStart before waiting for min pool size?

Copy link
Member Author

@vbabanin vbabanin Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timeouts were caused by a non–spec-compliant unified test in the specification repo. I added a code comment and ignored these tests in UnifiedTestModifications, after confirming with the author that they should be fixed upstream.

In any case, I agree that waitForPoolAsyncWorkManagerStart should come first, so I’ve moved it accordingly.

}
}

public void clearEvents() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this isn't used and can be reverted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I accidentally marked this as ready for review. it was meant to stay in draft to run the tests with clearing events and not clearing events. I removed those unused methods and added a code comment why we are not clearing events. Thanks!

}
}

public synchronized void clearMessages() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this isn't used and can be reverted

Comment on lines 604 to 606
// testConnectionPoolListener.clearEvents();
// getClientLoggingInterceptor(id).clearMessages();
} catch (TimeoutException | InterruptedException e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// testConnectionPoolListener.clearEvents();
// getClientLoggingInterceptor(id).clearMessages();
} catch (TimeoutException | InterruptedException e) {
} catch (TimeoutException | InterruptedException e) {

@vbabanin vbabanin marked this pull request as draft October 9, 2025 19:37
@vbabanin vbabanin marked this pull request as ready for review October 10, 2025 18:27
@vbabanin vbabanin requested a review from rozza October 10, 2025 20:54
@vbabanin vbabanin self-assigned this Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants