-
Notifications
You must be signed in to change notification settings - Fork 140
feat: Add Atlas Local Tools #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@nirinchev @kmruiz @himanshusinghs All PRs to the feature branch has been reviewed but we would like someone from DevTools to review before merging to main please :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone through the code, but not through the tests yet. There are a couple of suggested changes that will impact the test structure, so I'll hold off on reviewing the tests until those are applied.
…eview/atlas-local package, use string union version of CreationSourceType
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still have to go through the tests, but the implementation seems to be mostly there. I have a few nits, as well as some concerns, but those are not super blocking.
…er to original implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should run the accuracy tests once we've fixed the mocks to check that they're indeed passing - I'd be very surprised if they do with the current wording of the prompts.
Co-authored-by: Nikola Irinchev <irinchev@me.com>
Co-authored-by: Nikola Irinchev <irinchev@me.com>
Co-authored-by: Nikola Irinchev <irinchev@me.com>
📊 Accuracy Test Results📈 Summary
📊 Baseline Comparison
📎 Download Full HTML Report - Look for the Report generated on: 10/21/2025, 10:23:18 AM |
"node": "^20.19.0 || ^22.12.0 || >= 23.0.0" | ||
}, | ||
"optionalDependencies": { | ||
"@mongodb-js/atlas-local": "^1.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this meant to be an optional dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it is, the import might not succeed on all platforms.
…g a deployment that already exists'
I ran the accuracy tests and all the |
Proposed changes
Jira: MCP-40
Checklist