-
Notifications
You must be signed in to change notification settings - Fork 231
chore(components): upgrade LeafyGreen components COMPASS-9642 #7406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
kraenhansen
wants to merge
32
commits into
main
Choose a base branch
from
kh/leafygreen-update-october-2025
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12,838
−10,452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
commented
Oct 1, 2025
|
||
useLayoutEffect(() => { | ||
if (autoFocus) { | ||
throw new Error('BaseEditor is missing an implementation of autoFocus'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing an implementation and tests.
kraenhansen
commented
Oct 1, 2025
const editorRef = React.createRef<EditorRef>(); | ||
render( | ||
<CodemirrorMultilineEditor text={'{}'} autoFocus ref={editorRef} /> | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test needs an assertion that the editor is actually getting focussed.
f8901ae
to
3c55834
Compare
This was fixed in LG-5063
3c55834
to
8f37680
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
no release notes
Fix or feature not for release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging this PR will:
jsdom
missing support forHTMLDialogElement
:compass/configs/mocha-config-compass/register/jsdom-extra-mocks-register.js
Lines 38 to 51 in 3c55834
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes