Using descriptor_class from Django 3.0 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baobab-ai
commented
Feb 7, 2020
| 'by_id': {self.id: self}, | ||
| 'by_name': {self.name: self} | ||
| } | ||
| cls._meta._field_tof['by_id'].update({self.id: self}) |
There was a problem hiding this comment.
@mom1 The original pull request had an issue, now this should do the work, originally there was setattr with nested setdefault. It was quite hard to read and understand. Also, I hope that a good idea to add more tests for core functionality.
|
Thanks for the pull request. Now I don’t have time, but I’ll definitely look at your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to ask if you have any questions about the pull request.