Skip to content

Shellcheck #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Shellcheck #246

wants to merge 21 commits into from

Conversation

hucste
Copy link

@hucste hucste commented Jan 13, 2019 •
edited
Loading

New attempt segun @itoffshore notes:

  • create new branche named shellcheck
  • revert by copy'n paste all code on official updater script
  • add desired corrections shellcheck

Hope, it's good!?

hucste added 21 commits January 2, 2019 20:18
@hucste
fix: shellcheck SC2039, in Posix, local is undefined
d72f038
@hucste
fix: shellcheck SC1007, for empty var, use var=''
ef1ba95
@hucste
fix: shellcheck SC2086, double quote...
81379c1
@hucste
fix: shellcheck SC2059, use printf '..%s..' ""
96b9042
@hucste
fix: shellcheck SC2230, use 'command -v' instead of 'wich'
b25a412
@hucste
fix: shellcheck SC2062, quote the grep pattern
609511f
@hucste
fix: shellcheck SC2046, quote to prevent word splitting
46430a8
@hucste
fix: shellcheck SC2124, use * instead of @
43db6c4
@hucste
fix: shellcheck SC2068, double quotes array
ea28494
@hucste
fix: print messages
d5ff386
@hucste
fix: shellcheck SC2069, clarify redirect 2&1
981b1dd
@hucste
fix: Curl detection
d72cc3f
@hucste
fix: shellcheck SC2002, useless cat
4f221e9
@hucste
fix: shellcheck SC2181, check exit code directly
b39866b
@hucste
refactor: awk instead of grep | sed | ...
4e69833
@hucste
refactor: var, and informations
b1f4fe3
@hucste
fix: delete code for CRON var
8bd8b21
@hucste
revert: revert all previous commits!
6ecf273
@hucste
fix: shellcheck SC2059, use printf '..%s..'
9e04b09
@hucste
fix: shellcheck SC2230, use 'command -v' instead of 'which'
b011177
@hucste
fix: shellcheck SC2062, quote the grep pattern
a772ecd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hucste