-
Notifications
You must be signed in to change notification settings - Fork 451
[DataGrid] Asynchronous IQueryable based loading and error handling UI feedback #4177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
[DataGrid] Asynchronous IQueryable based loading and error handling UI feedback #4177
Conversation
The We cannot just alter the test to make it pass with the new code. That would mean we introduce a breaking change (albeit a small one) Please review the PR and make the necessary changes so all tests pass unaltered. Thanks |
</FluentDataGridRow> | ||
} | ||
|
||
private void RenderErrorContent(RenderTreeBuilder __builder) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot display a default technical error to the user via _lastError.Message
. This can lead to serious security issues in production environments.
It is possible to capture a potential exception, but in that case, ErrorContent
or a standard message such as "An error occurred while retrieving data" must be displayed.
This RenderErrorContent method needs to be reviewed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dvoituron good point. I'll make the appropriate changes.
@vnbaaij I'll check the failing unit test and apply required fixes. Thanks |
Pull Request
📖 Description
This feature introduces two visual enhancements to the DataGrid component while asynchronously loading items from an IQueryable data source:
👩💻 Reviewer Notes
A working sample of the 'Loading' state flag feature can be seen in the following samples:
These same samples can be used to see a working sample for the error handling feature by forcing data source connection errors.
✅ Checklist
General
Component-specific