Compilation failed error message #497
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 8, 2025 12:53
yangpanMS
reviewed
Apr 28, 2025
| { | ||
| if (process.IsErrored()) | ||
| { | ||
| await this.LogProcessDetailsAsync(process, telemetryContext, "HPLinpack", logToFile: true); |
There was a problem hiding this comment.
the logProcessDetails should be outside of the process.IsErrored, also someworkloads should already be logging process details, see if there are duplications
Signed-off-by: Sai Bulusu <sai.bulusu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error message 513.
Tested on SFR and LMBench when gcc and make are not installed. However, the error message itself does not appear right now.
Clarification: should we add logging to process.ThrowIfErrored to include the error message?