Skip to content

Conversation

Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Sep 23, 2025

Description

Please briefly explain the changes you made here.

Pull request type

  • Bugfix
  • Algorithm/Module
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Related issues

Delete if this PR doesn't resolve any issues. Link the issue if it does.

######################################

Reviewer checklist (the reviewer checks this part)

Module/Algorithm

  • Core algorithm/module implementation
  • Query module implementation
  • Tests provided (unit / e2e)
  • Code documentation
  • README short description

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Fixed map.merge module to accept nullable arguments #671
  • Link the documentation PR here

@Josipmrden Josipmrden self-assigned this Sep 23, 2025
@Josipmrden Josipmrden added bug bug customer customer labels Sep 23, 2025
@Josipmrden Josipmrden added this to the mage-v3.5.2 milestone Sep 23, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

- name: Check mgdeps-cache availability
run: |
if curl --silent --fail "http://mgdeps-cache:8000/wheels/" -o /dev/null; then
if [ "${{ inputs.arch }}" == "amd64" ]; then

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed in my reworking of all of MAGE's workflows.

- name: Check mgdeps-cache availability
run: |
if curl --silent --fail "http://mgdeps-cache:8000/wheels/" -o /dev/null; then
if [ "${{ inputs.arch }}" == "amd64" ]; then

Check failure

Code scanning / SonarCloud

GitHub Actions should not be vulnerable to script injections High

Change this workflow to not use user-controlled data directly in a run block. See more on SonarQube Cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be fixed in my reworking of all of MAGE's workflows.

@Josipmrden Josipmrden merged commit c26f645 into main Sep 23, 2025
7 of 9 checks passed
@Josipmrden Josipmrden deleted the merge-properties-edge-case-null branch September 23, 2025 11:27
mattkjames7 pushed a commit that referenced this pull request Sep 23, 2025
@Josipmrden Josipmrden added the Docs needed Docs needed label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug bug customer customer Docs needed Docs needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants