-
Notifications
You must be signed in to change notification settings - Fork 148
v1 API increase coverage - write operation #2623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grusev
wants to merge
15
commits into
master
Choose a base branch
from
v1_api_write_new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-D-Petrov
reviewed
Sep 11, 2025
sym: str = "__qwerty124" | ||
|
||
nvs: NativeVersionStore = version_store_and_real_s3_basic_store_factory( | ||
dynamic_schema=True, segment_row_size=(max_length // 2), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I'd put all of these as params to the test and test with both dynamic_schema=True
and dynamic_schema=False
python/tests/integration/arcticdb/version_store/test_basic_operations_scenarios.py
Outdated
Show resolved
Hide resolved
d558427
to
72ae745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
The goal for this PR is to improve coverage of v1 API write() method. Initial analysis showed that not all types of data was used in the existing tests and not every combination of parameters is examined.
The result is a single scenario test that loops through all combination of parameters and executing different write operarions with all supported data types. Unlike existing tests this scenario loops through series of writes and reads on single symbol without wiping out after each one. Thus the test also examines that all write operation types can be performed on a single symbol.
As most of the actual usage of Arctic is actually with sparse data, and such thing was not present in the tests. A number of enhancements for utility functions have been made to be possible to produce sparse arrays and dataframes., which are used primerily in this test but are intended to be used in other future tests also.
2 interesting observations were made during the test, which could be considered issues or known limitations:
Any other comments?
Checklist
Checklist for code changes...