DO NOT MERGE: Parametrize all pipeline tests to run with arrow output format #2610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Label error. Requires exactly 1 of: patch, minor, major. Found: |
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
2 times, most recently
from
d6e7c85 to
d7d1877
Compare
`NullReducer` code was assuming that `len(slice_and_keys) = len(row_slices_per_column)` when using `dynamic_schema=True`.
That is not true if we use projections.
This PR modifies `NullReducer` code to not rely on the slice index and
by preserving a `column_block_offset_` state avoids an unneeded `log(n)` search for the offset.
E.g. for the following projection our slicing would look like:
```
Given:
TD key 1:
index A
1 1
2 2
TD key 2:
index A B
3 3 1
4 4 2
TD key 3:
index B
5 3
6 4
And we do a projection like `q.apply("C", q["A"] + q["B"])` our slicing would look
like:
Slice 1: TD key 1
Slice 2: TD key 2
Slice 3:
index C
3 4
4 6
Slice 4: TD key 3
```
When doing aggregation we explicitly default `sum=0` for slices with no underlying values. For arrow this means to not set the validity bitmap in this case and to default initialize the values. The change includes: - Small refactor of `NullReducer` to extract common parts between `reduce` and `finalize` in `backfill_up_to_frame_offset` - Modification of `Column::default_initialize` to work across several blocks - Removes broken `memset` method from `ChunkedBuffer` and instead provides a new `util::initialize` method which can initialize a `ChunkedBuffer` across blocks
- Add comment explaining `byte_blocks_at` - Remove leftover prints
- Makes Aggregation clauses like `Mean` and `Count` respect input column sparsity - Fixes `CopyToBufferTask` to respect sparsity for arrow
Also discovered an issue with appending an empty column set. Added an xfail test for it and an issue 10029194063
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
from
d7d1877 to
8629499
Compare
IvoDD
force-pushed
the
run-all-pipeline-tests
branch
from
8629499 to
8df2f0e
Compare
IvoDD
force-pushed
the
fix-sparse-buffer-processing
branch
2 times, most recently
from
6570743 to
c8a0745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...