Skip to content

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Sep 24, 2025

Issue

  • Requested by @MH4GF in Slack to configure useFilenamingConvention rule and measure lint error count

Why is this change needed?

This change adds the Biome useFilenamingConvention linting rule to enforce consistent filename casing conventions across the codebase. The rule is configured to accept camelCase, PascalCase, or filenames that match export names.

Changes

  • Added useFilenamingConvention rule to shared Biome configuration
  • Rule configured with filenameCases: ["camelCase", "PascalCase", "export"]
  • Set to "error" level to enforce the convention

Impact

This rule generates 7 lint errors across 4 packages:

  • @liam-hq/app: 3 errors (global-error.tsx, instrumentation-client.ts, install-prisma-internals.mjs)
  • @liam-hq/docs: 2 errors (global-error.tsx, instrumentation-client.ts)
  • @liam-hq/cli: 1 error (vite-env.d.ts)
  • @liam-hq/pglite-server: 1 error (PGliteInstanceManager.test.ts)

⚠️ Important: Per the original request, these lint errors are intentionally left unfixed to measure the impact. The frontend-lint CI check will fail until these files are renamed.

Review Checklist

  • Verify the Biome rule configuration syntax is correct
  • Confirm that leaving lint errors unfixed is intentional per requirements
  • Check that the rule is placed appropriately in the config structure
  • Consider impact on development workflow with failing CI

Link to Devin run: https://app.devin.ai/sessions/720510d65dce464ca7aa5f3f0ffdfb95
Requested by: @MH4GF

- Configured Biome linter to enforce filename conventions
- Rule generates 6 lint errors across 3 packages:
  - frontend/apps/app: 3 errors
  - frontend/apps/docs: 2 errors
  - frontend/packages/cli: 1 error
- Errors are intentionally not fixed per user request

Co-Authored-By: hirotaka.miyagi@route06.co.jp <h.miyagi.cnw@gmail.com>
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link

changeset-bot bot commented Sep 24, 2025

⚠️ No Changeset found

Latest commit: a4a1264

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Sep 24, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

vercel bot commented Sep 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Sep 24, 2025 11:34am
liam-assets Ready Ready Preview Comment Sep 24, 2025 11:34am
liam-erd-sample Ready Ready Preview Comment Sep 24, 2025 11:34am
liam-storybook Ready Ready Preview Comment Sep 24, 2025 11:34am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
liam-docs Ignored Ignored Sep 24, 2025 11:34am

Copy link

supabase bot commented Sep 24, 2025

Updates to Preview Branch (devin/1758712860-add-filename-convention-rule) ↗︎

Deployments Status Updated
Database Wed, 24 Sep 2025 11:25:44 UTC
Services Wed, 24 Sep 2025 11:25:44 UTC
APIs Wed, 24 Sep 2025 11:25:44 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Wed, 24 Sep 2025 11:25:49 UTC
Migrations Wed, 24 Sep 2025 11:25:51 UTC
Seeding Wed, 24 Sep 2025 11:25:55 UTC
Edge Functions Wed, 24 Sep 2025 11:25:55 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant