-
Notifications
You must be signed in to change notification settings - Fork 173
Add useFilenamingConvention rule to Biome config #3586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add useFilenamingConvention rule to Biome config #3586
Conversation
- Configured Biome linter to enforce filename conventions - Rule generates 6 lint errors across 3 packages: - frontend/apps/app: 3 errors - frontend/apps/docs: 2 errors - frontend/packages/cli: 1 error - Errors are intentionally not fixed per user request Co-Authored-By: hirotaka.miyagi@route06.co.jp <h.miyagi.cnw@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Updates to Preview Branch (devin/1758712860-add-filename-convention-rule) ↗︎
Tasks are run on every commit but only new migration files are pushed.
View logs for this Workflow Run ↗︎. |
Issue
useFilenamingConvention
rule and measure lint error countWhy is this change needed?
This change adds the Biome
useFilenamingConvention
linting rule to enforce consistent filename casing conventions across the codebase. The rule is configured to acceptcamelCase
,PascalCase
, or filenames that match export names.Changes
useFilenamingConvention
rule to shared Biome configurationfilenameCases: ["camelCase", "PascalCase", "export"]
Impact
This rule generates 7 lint errors across 4 packages:
@liam-hq/app
: 3 errors (global-error.tsx, instrumentation-client.ts, install-prisma-internals.mjs)@liam-hq/docs
: 2 errors (global-error.tsx, instrumentation-client.ts)@liam-hq/cli
: 1 error (vite-env.d.ts)@liam-hq/pglite-server
: 1 error (PGliteInstanceManager.test.ts)frontend-lint
CI check will fail until these files are renamed.Review Checklist
Link to Devin run: https://app.devin.ai/sessions/720510d65dce464ca7aa5f3f0ffdfb95
Requested by: @MH4GF