Skip to content

Conversation

tnyo43
Copy link
Member

@tnyo43 tnyo43 commented Sep 15, 2025

Issue

  • resolve:

Why is this change needed?

This PR will improve performances with hash interactions:

  • modifying hash and scrolling to element
  • removing hash when active table is modified or removed

modifying hash and scrolling to element

Not that big improvement in the video 😂 but happens when you select column item link (especially in Safari)

before

Screen.Recording.0007-09-15.at.12.37.03.mov

after

Screen.Recording.0007-09-15.at.12.36.11.mov

removing hash when active table is modified or removed

before

Screen.Recording.0007-09-15.at.22.40.51.mov

after

Screen.Recording.0007-09-15.at.22.42.17.mov

Copy link

changeset-bot bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: 0604f68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@liam-hq/erd-core Patch
@liam-hq/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
liam-app Ready Ready Preview Comment Sep 15, 2025 3:14am
liam-assets Ready Ready Preview Comment Sep 15, 2025 3:14am
liam-erd-sample Ready Ready Preview Comment Sep 15, 2025 3:14am
liam-storybook Ready Ready Preview Comment Sep 15, 2025 3:14am
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
liam-docs Ignored Ignored Sep 15, 2025 3:14am

Copy link
Contributor

coderabbitai bot commented Sep 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pref/hash-transition

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

supabase bot commented Sep 15, 2025

Updates to Preview Branch (pref/hash-transition) ↗︎

Deployments Status Updated
Database Mon, 15 Sep 2025 03:11:18 UTC
Services Mon, 15 Sep 2025 03:11:18 UTC
APIs Mon, 15 Sep 2025 03:11:18 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks Status Updated
Configurations Mon, 15 Sep 2025 03:11:25 UTC
Migrations Mon, 15 Sep 2025 03:11:27 UTC
Seeding Mon, 15 Sep 2025 03:11:27 UTC
Edge Functions Mon, 15 Sep 2025 03:11:28 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

Base automatically changed from feat/link-to-column-item to main September 22, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant